Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using Program and attempting to --dry-run throws an exception #26

Open
dogonthehorizon opened this issue Apr 6, 2018 · 0 comments
Open

Using Program and attempting to --dry-run throws an exception #26

dogonthehorizon opened this issue Apr 6, 2018 · 0 comments
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed

Comments

@dogonthehorizon
Copy link
Contributor

When using a signal_analog.flow.Program one would expect that --dry-run would spit out the configuration for whatever resource we're creating. Instead we're treated with a nasty error:

TypeError: Object of type 'Program' is not JSON serializable

This shouldn't happen!

A good approach is going to be to make sure that whenever we call dry-run all resources have been properly serialized (e.g. Program should be turned into a string before printing)
@dogonthehorizon dogonthehorizon added bug Something isn't working help wanted Extra attention is needed good first issue Good for newcomers labels Apr 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dogonthehorizon