From c4f5124f5dfb6317ab12b1fcd09ef263a771d798 Mon Sep 17 00:00:00 2001
From: Neuroquila-n8fall <david.ginsbach@googlemail.com>
Date: Fri, 7 Oct 2022 08:24:44 +0200
Subject: [PATCH 01/14] remove unused variable

---
 src/webconfig.cpp | 1 -
 1 file changed, 1 deletion(-)

diff --git a/src/webconfig.cpp b/src/webconfig.cpp
index fb4ffcd..0fe9389 100644
--- a/src/webconfig.cpp
+++ b/src/webconfig.cpp
@@ -4,7 +4,6 @@ AsyncWebServer *server;
 AsyncEventSource *eventSource;
 
 volatile bool ShouldReboot = false;
-static size_t content_len;
 
 void StartApMode()
 {

From 05f2aaddd60408fbef51a0a36c8483d47eef5a96 Mon Sep 17 00:00:00 2001
From: Neuroquila-n8fall <david.ginsbach@googlemail.com>
Date: Fri, 7 Oct 2022 08:25:16 +0200
Subject: [PATCH 02/14] Fix: Reboot ESP when requested by web interface

---
 src/main.cpp | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/src/main.cpp b/src/main.cpp
index cdfe654..ef97381 100644
--- a/src/main.cpp
+++ b/src/main.cpp
@@ -146,6 +146,14 @@ Serial.println("\e[1;36mSetup Mode not enabled. You can enable it at every time
 
 void loop()
 {
+  // Init reboot if requested
+  if (ShouldReboot) {
+    WiFi.disconnect();
+    server->end();
+    vTaskDelay(3000 / portTICK_PERIOD_MS);
+    ESP.restart();
+  }
+
   // Stop executing when SetupMode is active.
   if (SetupMode)
   {

From ce1f115fe7166b71cb3d8dd49764ec66e109fd28 Mon Sep 17 00:00:00 2001
From: Neuroquila-n8fall <david.ginsbach@googlemail.com>
Date: Fri, 7 Oct 2022 08:25:25 +0200
Subject: [PATCH 03/14] Fix typo

---
 src/main.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/main.cpp b/src/main.cpp
index ef97381..f323266 100644
--- a/src/main.cpp
+++ b/src/main.cpp
@@ -237,7 +237,7 @@ void loop()
       // We can only "suggest" to set to a certain temperature or switching off the pump(s)
 
       // I have "borrowed" the concept of a step-chain from PLC programming since it appears
-      //   to have been incoorporated into the controller as well because values arrive in
+      //   to have been incorporated into the controller as well because values arrive in
       //   intervals of approximately 1 second.
 
       CANMessage msg;

From 34aeaa866ba97a863a807c24ecc4c49bc9f453d2 Mon Sep 17 00:00:00 2001
From: Neuroquila-n8fall <david.ginsbach@googlemail.com>
Date: Fri, 7 Oct 2022 08:39:30 +0200
Subject: [PATCH 04/14] Delete unused function

---
 src/webconfig.cpp | 13 -------------
 1 file changed, 13 deletions(-)

diff --git a/src/webconfig.cpp b/src/webconfig.cpp
index 0fe9389..9a96d2c 100644
--- a/src/webconfig.cpp
+++ b/src/webconfig.cpp
@@ -927,16 +927,3 @@ void getSystemStatus(AsyncWebServerRequest *request)
 
     sendJson(doc, request);
 }
-
-// Make size of files human readable
-String humanReadableSize(const size_t bytes)
-{
-    if (bytes < 1024)
-        return String(bytes) + " B";
-    else if (bytes < (1024 * 1024))
-        return String(bytes / 1024.0) + " KB";
-    else if (bytes < (1024 * 1024 * 1024))
-        return String(bytes / 1024.0 / 1024.0) + " MB";
-    else
-        return String(bytes / 1024.0 / 1024.0 / 1024.0) + " GB";
-}

From 70d222f32c1ce4aec96acffb7ff8e0234445bcbd Mon Sep 17 00:00:00 2001
From: Neuroquila-n8fall <david.ginsbach@googlemail.com>
Date: Fri, 7 Oct 2022 08:41:27 +0200
Subject: [PATCH 05/14] Use long type for interpolation

---
 src/main.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/main.cpp b/src/main.cpp
index f323266..ed0933e 100644
--- a/src/main.cpp
+++ b/src/main.cpp
@@ -506,7 +506,7 @@ void SetDateTime()
       msg.data[3] = 4;
       if (configuration.General.Debug)
       {
-        Log.printf("DEBUG: Date and Time DOW:%i H:%i M:%i\r\n", myTZ.dateTime("N").toInt(), myTZ.hour(), myTZ.minute());
+        Log.printf("DEBUG: Date and Time DOW:%li H:%i M:%i\r\n", myTZ.dateTime("N").toInt(), myTZ.hour(), myTZ.minute());
       }
 
       SendMessage(msg);

From 002b6fa634d8e37b253e5416d008ab49dd86c3bb Mon Sep 17 00:00:00 2001
From: Neuroquila-n8fall <david.ginsbach@googlemail.com>
Date: Fri, 7 Oct 2022 08:41:58 +0200
Subject: [PATCH 06/14] Formatting

... use auto type for millis
---
 src/wifi_config.cpp | 11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)

diff --git a/src/wifi_config.cpp b/src/wifi_config.cpp
index 0cf2000..b8a811f 100644
--- a/src/wifi_config.cpp
+++ b/src/wifi_config.cpp
@@ -27,12 +27,15 @@ void connectWifi()
     WiFi.disconnect();
     WiFi.setHostname(configuration.Wifi.Hostname);
     WiFi.mode(WIFI_STA);
-    
+
     Serial.println("WiFi not connected. Reconnecting...");
 
-    if(configuration.General.Debug)
-    Serial.printf("Connecting to %s using password %s and hostname %s \r\n", configuration.Wifi.SSID, configuration.Wifi.Password, configuration.Wifi.Hostname);
-    unsigned long prevConnectMillis = millis();
+    if(configuration.General.Debug) {
+      Serial.printf("Connecting to %s using password %s and hostname %s \r\n", configuration.Wifi.SSID,
+                    configuration.Wifi.Password, configuration.Wifi.Hostname);
+    }
+
+    auto prevConnectMillis = millis();
     WiFi.begin(configuration.Wifi.SSID, configuration.Wifi.Password);
     while (WiFi.waitForConnectResult() != WL_CONNECTED)
     {

From 8cbf22abff36d840f7bf9c22a20d1c47b89ce3a6 Mon Sep 17 00:00:00 2001
From: Neuroquila-n8fall <david.ginsbach@googlemail.com>
Date: Fri, 7 Oct 2022 08:45:52 +0200
Subject: [PATCH 07/14] Replace 'var'

---
 data/frontend/canalyzer.html | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/data/frontend/canalyzer.html b/data/frontend/canalyzer.html
index a8cce81..a3d17cc 100644
--- a/data/frontend/canalyzer.html
+++ b/data/frontend/canalyzer.html
@@ -90,8 +90,8 @@ <h3>Watch CAN Messages</h3>
         }
 
         async function loadKnownAddresses() {
-            var addresses = await getConfigJson("/api/config/canbus");
-            var keys = getDeepKeys(addresses);            
+            const addresses = await getConfigJson("/api/config/canbus");
+            const keys = getDeepKeys(addresses);
             keys.forEach(e => {
                 let value = jsonPathToValue(addresses, e);
                 knownAddresses.push(value);
@@ -126,7 +126,7 @@ <h3>Watch CAN Messages</h3>
         */
         function addToKnownAddress(id) {
             const msgId = `0x${id.toUpperCase()}`;
-            var found = unknownAddresses.findIndex((e) => e === msgId);
+            const found = unknownAddresses.findIndex((e) => e === msgId);
             unknownAddresses.slice(found, 1);
             _(`${id.toLowerCase()}-unknown`).remove();
             knownAddresses.push(`0x${id}`);
@@ -143,7 +143,7 @@ <h3>Watch CAN Messages</h3>
         */
         function addUnknownAddress(id) {
             const msgId = `0x${id.toUpperCase()}`;
-            var found = knownAddresses.findIndex((e) => e === msgId);
+            const found = knownAddresses.findIndex((e) => e === msgId);
             if(found > -1) {
                 unknownAddresses.slice(found, 1);
                 _(`${id.toLowerCase()}-enabled`).remove();
@@ -265,7 +265,7 @@ <h3>Watch CAN Messages</h3>
             }
 
             function decimalToHex(d, padding) {
-                var hex = Number(d).toString(16);
+                let hex = Number(d).toString(16);
                 padding = typeof (padding) === "undefined" || padding === null ? padding = 2 : padding;
 
                 while (hex.length < padding) {
@@ -276,10 +276,10 @@ <h3>Watch CAN Messages</h3>
             }
 
             function startEvents(){
-              var es = new EventSource('/events');
-              es.addEventListener('can', function(e) {
+                const es = new EventSource('/events');
+                es.addEventListener('can', function(e) {
                 addMessage(e.data);
-              }, false);
+                }, false);
             }
     </script>
 </body>
\ No newline at end of file

From 3f1d647418b64dc89ddfc58610f7aa265258cade Mon Sep 17 00:00:00 2001
From: Neuroquila-n8fall <david.ginsbach@googlemail.com>
Date: Fri, 7 Oct 2022 08:46:56 +0200
Subject: [PATCH 08/14] Formatting

---
 data/frontend/canalyzer.html | 444 ++++++++++++++++++-----------------
 1 file changed, 233 insertions(+), 211 deletions(-)

diff --git a/data/frontend/canalyzer.html b/data/frontend/canalyzer.html
index a3d17cc..7372ab9 100644
--- a/data/frontend/canalyzer.html
+++ b/data/frontend/canalyzer.html
@@ -10,225 +10,247 @@
 </head>
 
 <body>
-    <div id="navigation-container">
-        <!-- Navigation Placeholder -->
-    </div>
-    <div class="container text-center">
-        <div class="row">
-            <div class="col-md-3 text-start">
-                <div class="row mt-5">
-                    <h4>Options and Utilities</h4>
-                    <div class="form-check form-switch">
-                        <input class="form-check-input" type="checkbox" role="switch" id="ignoreKnown">
-                        <label class="form-check-label" for="ignoreKnown">Ignore Known Addresses</label>
-                    </div>
-                </div>
-                <div>
-                    <h5>Known Addresses</h5>
-                    <div class="row mt-3" id="known-addresses">
-                        <!-- Known Address Switches -->
-                    </div>
-                </div>
-                <div>
-                    <h5>Unknown Addresses</h5>
-                    <div class="row mt-3" id="unknown-addresses">
-                        <!-- Unknown Address Buttons -->
-                    </div>
+<div id="navigation-container">
+    <!-- Navigation Placeholder -->
+</div>
+<div class="container text-center">
+    <div class="row">
+        <div class="col-md-3 text-start">
+            <div class="row mt-5">
+                <h4>Options and Utilities</h4>
+                <div class="form-check form-switch">
+                    <input class="form-check-input" type="checkbox" role="switch" id="ignoreKnown">
+                    <label class="form-check-label" for="ignoreKnown">Ignore Known Addresses</label>
                 </div>
             </div>
-            <div class="col-md-6">
-                <!-- Content -->
-                <div class="row mt-5">
-                    <h3>Watch CAN Messages</h3>
+            <div>
+                <h5>Known Addresses</h5>
+                <div class="row mt-3" id="known-addresses">
+                    <!-- Known Address Switches -->
                 </div>
-                <div class="row mt-5 overflow-auto border border-1 rounded align-content-start" id="can-msg-log" style="height: 500px">
-                    <table class="table table-bordered align-top">
-                        <thead class="sticky-top bg-light">
-                            <tr class="sticky-top bg-light">
-                                <th class="sticky-top" style="box-shadow: inset 1px 1px var(--bs-border-color), 0 1px var(--bs-border-color);">&#8651;</th>
-                                <th class="sticky-top" style="box-shadow: inset 1px 1px var(--bs-border-color), 0 1px var(--bs-border-color);">ID</th>                                
-                                <th class="sticky-top" style="box-shadow: inset 1px 1px var(--bs-border-color), 0 1px var(--bs-border-color);">1</th>
-                                <th class="sticky-top" style="box-shadow: inset 1px 1px var(--bs-border-color), 0 1px var(--bs-border-color);">2</th>
-                                <th class="sticky-top" style="box-shadow: inset 1px 1px var(--bs-border-color), 0 1px var(--bs-border-color);">3</th>
-                                <th class="sticky-top" style="box-shadow: inset 1px 1px var(--bs-border-color), 0 1px var(--bs-border-color);">4</th>
-                                <th class="sticky-top" style="box-shadow: inset 1px 1px var(--bs-border-color), 0 1px var(--bs-border-color);">5</th>
-                                <th class="sticky-top" style="box-shadow: inset 1px 1px var(--bs-border-color), 0 1px var(--bs-border-color);">6</th>
-                                <th class="sticky-top" style="box-shadow: inset 1px 1px var(--bs-border-color), 0 1px var(--bs-border-color);">7</th>
-                                <th class="sticky-top" style="box-shadow: inset 1px 1px var(--bs-border-color), 0 1px var(--bs-border-color);">8</th>
-                            </tr>
-                        </thead>
-                        <tbody id="can-msg">
-
-                        </tbody>
-                    </table>
+            </div>
+            <div>
+                <h5>Unknown Addresses</h5>
+                <div class="row mt-3" id="unknown-addresses">
+                    <!-- Unknown Address Buttons -->
                 </div>
             </div>
-            <div class="col-md-3">
+        </div>
+        <div class="col-md-6">
+            <!-- Content -->
+            <div class="row mt-5">
+                <h3>Watch CAN Messages</h3>
+            </div>
+            <div class="row mt-5 overflow-auto border border-1 rounded align-content-start" id="can-msg-log"
+                 style="height: 500px">
+                <table class="table table-bordered align-top">
+                    <thead class="sticky-top bg-light">
+                    <tr class="sticky-top bg-light">
+                        <th class="sticky-top"
+                            style="box-shadow: inset 1px 1px var(--bs-border-color), 0 1px var(--bs-border-color);">
+                            &#8651;
+                        </th>
+                        <th class="sticky-top"
+                            style="box-shadow: inset 1px 1px var(--bs-border-color), 0 1px var(--bs-border-color);">ID
+                        </th>
+                        <th class="sticky-top"
+                            style="box-shadow: inset 1px 1px var(--bs-border-color), 0 1px var(--bs-border-color);">1
+                        </th>
+                        <th class="sticky-top"
+                            style="box-shadow: inset 1px 1px var(--bs-border-color), 0 1px var(--bs-border-color);">2
+                        </th>
+                        <th class="sticky-top"
+                            style="box-shadow: inset 1px 1px var(--bs-border-color), 0 1px var(--bs-border-color);">3
+                        </th>
+                        <th class="sticky-top"
+                            style="box-shadow: inset 1px 1px var(--bs-border-color), 0 1px var(--bs-border-color);">4
+                        </th>
+                        <th class="sticky-top"
+                            style="box-shadow: inset 1px 1px var(--bs-border-color), 0 1px var(--bs-border-color);">5
+                        </th>
+                        <th class="sticky-top"
+                            style="box-shadow: inset 1px 1px var(--bs-border-color), 0 1px var(--bs-border-color);">6
+                        </th>
+                        <th class="sticky-top"
+                            style="box-shadow: inset 1px 1px var(--bs-border-color), 0 1px var(--bs-border-color);">7
+                        </th>
+                        <th class="sticky-top"
+                            style="box-shadow: inset 1px 1px var(--bs-border-color), 0 1px var(--bs-border-color);">8
+                        </th>
+                    </tr>
+                    </thead>
+                    <tbody id="can-msg">
+
+                    </tbody>
+                </table>
             </div>
         </div>
+        <div class="col-md-3">
+        </div>
     </div>
+</div>
 
-    <script src="frontend/js/framework.js"></script>
-    <script src="frontend/js/api.js"></script>
-    <script src="frontend/js/firmware.js"></script>
-    <script src="frontend/js/bootstrap.bundle.min.js"></script>
-    <script type="text/javascript">
-        loadNavigation();
-        startEvents();
-        loadKnownAddresses();
-        let messages = [];
-        let knownAddresses = [];
-        let unknownAddresses = [];
-        let previousMessage = [];
+<script src="frontend/js/framework.js"></script>
+<script src="frontend/js/api.js"></script>
+<script src="frontend/js/firmware.js"></script>
+<script src="frontend/js/bootstrap.bundle.min.js"></script>
+<script type="text/javascript">
+    loadNavigation();
+    startEvents();
+    loadKnownAddresses();
+    let messages = [];
+    let knownAddresses = [];
+    let unknownAddresses = [];
+    let previousMessage = [];
 
-        const msgLog = _("can-msg");
-        
-        function Message() {
-            this.id = "",
+    const msgLog = _("can-msg");
+
+    function Message() {
+        this.id = "",
             this.len = 0,
             this.data = []
-        }
+    }
 
-        async function loadKnownAddresses() {
-            const addresses = await getConfigJson("/api/config/canbus");
-            const keys = getDeepKeys(addresses);
-            keys.forEach(e => {
-                let value = jsonPathToValue(addresses, e);
-                knownAddresses.push(value);
-            })
-            knownAddresses.sort();
-            knownAddresses.forEach((e) => {
-                _("known-addresses").innerHTML += `<div class="form-check form-switch">
+    async function loadKnownAddresses() {
+        const addresses = await getConfigJson("/api/config/canbus");
+        const keys = getDeepKeys(addresses);
+        keys.forEach(e => {
+            let value = jsonPathToValue(addresses, e);
+            knownAddresses.push(value);
+        })
+        knownAddresses.sort();
+        knownAddresses.forEach((e) => {
+            _("known-addresses").innerHTML += `<div class="form-check form-switch">
                         <input class="form-check-input" type="checkbox" role="switch" id="${e.toLowerCase()}-enabled" checked>
                         <label class="form-check-label" for="${e}-enabled">${e}</label>
                     </div>`;
-            })
-        }
+        })
+    }
 
-        function onSwitchAllAddresses() {
-            knownAddresses.forEach((e) => {
-                _(`${e}-label`).checked = _("ignoreKnown").checked;
-            });
-        }
+    function onSwitchAllAddresses() {
+        knownAddresses.forEach((e) => {
+            _(`${e}-label`).checked = _("ignoreKnown").checked;
+        });
+    }
 
-        function canIdKnown(id) {
-            return knownAddresses.some((x) => x.toUpperCase() === id.toUpperCase());
-        }
+    function canIdKnown(id) {
+        return knownAddresses.some((x) => x.toUpperCase() === id.toUpperCase());
+    }
 
-        function canIdIsInUnknown(id) {
-            return unknownAddresses.some((x) => x.toUpperCase() === id.toUpperCase());
-        }
+    function canIdIsInUnknown(id) {
+        return unknownAddresses.some((x) => x.toUpperCase() === id.toUpperCase());
+    }
 
-        /**
-         * Add ID to known addresses, removing existing buttons from the unknown group
-         * @param {string} id The ID without prefix '0x'
-         * @returns {undefined} Nothing
-        */
-        function addToKnownAddress(id) {
-            const msgId = `0x${id.toUpperCase()}`;
-            const found = unknownAddresses.findIndex((e) => e === msgId);
-            unknownAddresses.slice(found, 1);
-            _(`${id.toLowerCase()}-unknown`).remove();
-            knownAddresses.push(`0x${id}`);
-            _("known-addresses").innerHTML += `<div class="form-check form-switch">
+    /**
+     * Add ID to known addresses, removing existing buttons from the unknown group
+     * @param {string} id The ID without prefix '0x'
+     * @returns {undefined} Nothing
+     */
+    function addToKnownAddress(id) {
+        const msgId = `0x${id.toUpperCase()}`;
+        const found = unknownAddresses.findIndex((e) => e === msgId);
+        unknownAddresses.slice(found, 1);
+        _(`${id.toLowerCase()}-unknown`).remove();
+        knownAddresses.push(`0x${id}`);
+        _("known-addresses").innerHTML += `<div class="form-check form-switch">
                         <input class="form-check-input" type="checkbox" role="switch" id="0x${id.toLowerCase()}-enabled" checked>
                         <label class="form-check-label" for="${id}-enabled">${msgId}</label>
                     </div>`
-        }
+    }
 
-        /**
-         * Add ID to unknown addresses, removing existing switches from the known group
-         * @param {string} id The ID without prefix '0x'
-         * @returns {undefined} Nothing
-        */
-        function addUnknownAddress(id) {
-            const msgId = `0x${id.toUpperCase()}`;
-            const found = knownAddresses.findIndex((e) => e === msgId);
-            if(found > -1) {
-                unknownAddresses.slice(found, 1);
-                _(`${id.toLowerCase()}-enabled`).remove();
-            }
-            unknownAddresses.push(`0x${id.toUpperCase()}`);
-            _("unknown-addresses").innerHTML += `<div class="mb-3" id="${id.toLowerCase()}-unknown">
+    /**
+     * Add ID to unknown addresses, removing existing switches from the known group
+     * @param {string} id The ID without prefix '0x'
+     * @returns {undefined} Nothing
+     */
+    function addUnknownAddress(id) {
+        const msgId = `0x${id.toUpperCase()}`;
+        const found = knownAddresses.findIndex((e) => e === msgId);
+        if (found > -1) {
+            unknownAddresses.slice(found, 1);
+            _(`${id.toLowerCase()}-enabled`).remove();
+        }
+        unknownAddresses.push(`0x${id.toUpperCase()}`);
+        _("unknown-addresses").innerHTML += `<div class="mb-3" id="${id.toLowerCase()}-unknown">
                 <button type="button" class="btn btn-primary btn-sm" onClick="addToKnownAddress('${id}')">+</button>
                 <code>0x${id.toUpperCase()}</code>
                 </div>`
+    }
+
+    function checkPreviousMessage(message) {
+        // Check if a message on the specified ID has been already received
+        if (previousMessage.some((x) => x.id === message.id)) {
+            const found = previousMessage.findIndex((i) => i.id === message.id);
+            const prevMsgCopy = previousMessage[found];
+            previousMessage[found] = message;
+            // Report that copy back
+            return prevMsgCopy;
+        } else {
+            // Message ID hasn't been received yet. Add to array and return the received message.
+            previousMessage.push(message);
+            return message;
         }
 
-        function checkPreviousMessage(message) {
-            // Check if a message on the specified ID has been already received
-            if(previousMessage.some((x) => x.id === message.id)) {
-                const found = previousMessage.findIndex((i) => i.id === message.id);
-                const prevMsgCopy = previousMessage[found];
-                previousMessage[found] = message;
-                // Report that copy back
-                return prevMsgCopy;
+    }
+
+    // Returns an array of differences between data bytes from a and b
+    function compareValues(a, b) {
+        let resultArr = [];
+        // Pick the bigger array as the reference or
+        // just go with a and b if they are of equal size
+        const biggerArr = a.length >= b.length ? a : b;
+        for (let i = 0; i < biggerArr.length; i++) {
+            const first = a[i];
+            const second = b[i];
+            // ... in case the other array is smaller...
+            if (!second) {
+                resultArr.push(first);
             } else {
-                // Message ID hasn't been received yet. Add to array and return the received message.
-                previousMessage.push(message);                
-                return message;
+                resultArr.push(second - first);
             }
-
         }
+        return resultArr;
+    }
 
-        // Returns an array of differences between data bytes from a and b
-        function compareValues(a, b) {
-            let resultArr = [];
-            // Pick the bigger array as the reference or 
-            // just go with a and b if they are of equal size
-            const biggerArr = a.length >= b.length ? a : b;
-            for (let i = 0; i < biggerArr.length; i++) {
-                const first = a[i];
-                const second = b[i];
-                // ... in case the other array is smaller...
-                if(!second) {
-                    resultArr.push(first);
-                } else {
-                    resultArr.push(second-first);
-                }
-            }
-            return resultArr;
-        }
+    function addMessage(message) {
+        let json = JSON.parse(message);
+        let msgId = decimalToHex(json.id, 3);
 
-        function addMessage(message) {
-                let json = JSON.parse(message);
-                let msgId = decimalToHex(json.id,3);
+        // Ignore all known addresses, if option is active
+        if (_("ignoreKnown").checked && canIdKnown(`0x${msgId}`)) {
+            return;
+        }
 
-                // Ignore all known addresses, if option is active
-                if(_("ignoreKnown").checked && canIdKnown(`0x${msgId}`)) {
+        // Ignore unchecked IDs
+        if (canIdKnown(`0x${msgId}`)) {
+            const msgSwitch = _(`0x${msgId.toLowerCase()}-enabled`);
+            if (!msgSwitch) {
+                console.warn(`ID ${msgId} found but Switch is missing.`);
+            } else {
+                if (!msgSwitch.checked) {
                     return;
                 }
+            }
 
-                // Ignore unchecked IDs
-                if(canIdKnown(`0x${msgId}`)) {
-                    const msgSwitch = _(`0x${msgId.toLowerCase()}-enabled`);
-                    if(!msgSwitch) {
-                        console.warn(`ID ${msgId} found but Switch is missing.`);
-                    } else {
-                        if(!msgSwitch.checked) {
-                            return;
-                        }
-                    }
-
-                } else {
-                    if(!canIdIsInUnknown(`0x${msgId}`)) {
-                        addUnknownAddress(msgId);
-                    }                    
-                }
+        } else {
+            if (!canIdIsInUnknown(`0x${msgId}`)) {
+                addUnknownAddress(msgId);
+            }
+        }
 
-                messages.push(json);
-                // Track changes
-                const prevMsg = checkPreviousMessage(json);
+        messages.push(json);
+        // Track changes
+        const prevMsg = checkPreviousMessage(json);
 
-                const diffInValues = compareValues(prevMsg.data, json.data);
+        const diffInValues = compareValues(prevMsg.data, json.data);
 
-                let msgData = "";
-                const hasDifferentValues = diffInValues.some((x) => x !== 0);
-                try {                   
-                    json.data.forEach(e => {
-                    msgData += `<td><code>0x${decimalToHex(e,3).toUpperCase()}(${e})</code></td>`;
-                });
-                _("can-msg").innerHTML += `<tr ${hasDifferentValues ? "class=\"table-warning\"" : ""}>
+        let msgData = "";
+        const hasDifferentValues = diffInValues.some((x) => x !== 0);
+        try {
+            json.data.forEach(e => {
+                msgData += `<td><code>0x${decimalToHex(e, 3).toUpperCase()}(${e})</code></td>`;
+            });
+            _("can-msg").innerHTML += `<tr ${hasDifferentValues ? "class=\"table-warning\"" : ""}>
                                             <td>                                                    
                                                 ${json.rcv ? "&#11176;" : "&#11179;"}
                                             </td>
@@ -238,48 +260,48 @@ <h3>Watch CAN Messages</h3>
                                             </td>
                                                 ${msgData}
                                             </tr>`;
-                if(hasDifferentValues) {
-                    let diffMsg = "";
+            if (hasDifferentValues) {
+                let diffMsg = "";
 
-                    function numberWithPrefix(int) {
-                        let result = int > 0 ? "+" : "";
-                        result += int;
-                        return result;
-                    }
+                function numberWithPrefix(int) {
+                    let result = int > 0 ? "+" : "";
+                    result += int;
+                    return result;
+                }
 
-                    diffInValues.forEach((d) => {
-                            diffMsg += `<td><code>${d === 0 ? "" : numberWithPrefix(d) + "(dec)"}</code></td>`;
-                    })
-                    _("can-msg").innerHTML += `<tr class="table-info">
+                diffInValues.forEach((d) => {
+                    diffMsg += `<td><code>${d === 0 ? "" : numberWithPrefix(d) + "(dec)"}</code></td>`;
+                })
+                _("can-msg").innerHTML += `<tr class="table-info">
                                             <td colspan="2">
                                                 &Delta;
                                             </td>                                                
                                                 ${diffMsg}
                                             </tr>`;
-                }
-                } catch (error) {
-                    console.error(`Error displaying message with id 0x${msgId}: ${error}`)
-                }
-                //make the last element (a message) to scroll into view, smoothly!
-                msgLog.lastElementChild.scrollIntoView({ behavior: 'smooth' });
             }
+        } catch (error) {
+            console.error(`Error displaying message with id 0x${msgId}: ${error}`)
+        }
+        //make the last element (a message) to scroll into view, smoothly!
+        msgLog.lastElementChild.scrollIntoView({behavior: 'smooth'});
+    }
 
-            function decimalToHex(d, padding) {
-                let hex = Number(d).toString(16);
-                padding = typeof (padding) === "undefined" || padding === null ? padding = 2 : padding;
+    function decimalToHex(d, padding) {
+        let hex = Number(d).toString(16);
+        padding = typeof (padding) === "undefined" || padding === null ? padding = 2 : padding;
 
-                while (hex.length < padding) {
-                    hex = "0" + hex;
-                }
-            
-                return hex;
-            }
+        while (hex.length < padding) {
+            hex = "0" + hex;
+        }
 
-            function startEvents(){
-                const es = new EventSource('/events');
-                es.addEventListener('can', function(e) {
-                addMessage(e.data);
-                }, false);
-            }
-    </script>
+        return hex;
+    }
+
+    function startEvents() {
+        const es = new EventSource('/events');
+        es.addEventListener('can', function (e) {
+            addMessage(e.data);
+        }, false);
+    }
+</script>
 </body>
\ No newline at end of file

From 022988109f5e6756e1dae0d73304e866ed36e2ea Mon Sep 17 00:00:00 2001
From: Neuroquila-n8fall <david.ginsbach@googlemail.com>
Date: Fri, 7 Oct 2022 09:03:35 +0200
Subject: [PATCH 09/14] Refactoring

Use addEventListener instead of inline definition. Remove unused code and doubled attributes
---
 data/frontend/auxsensors.html | 16 ++++++++--------
 data/frontend/canbus.html     |  8 +++++---
 data/frontend/firmware.html   |  4 +++-
 data/frontend/general.html    |  6 ++++--
 data/frontend/leds.html       |  4 +++-
 data/frontend/mqtt.html       |  9 ++++++---
 data/frontend/reboot.html     | 27 +++++++++++++++------------
 data/frontend/wifi.html       |  6 ++++--
 8 files changed, 48 insertions(+), 32 deletions(-)

diff --git a/data/frontend/auxsensors.html b/data/frontend/auxsensors.html
index dfd6cc1..9807079 100644
--- a/data/frontend/auxsensors.html
+++ b/data/frontend/auxsensors.html
@@ -31,7 +31,7 @@ <h3>Auxiliary Sensors Configuration</h3>
                         <button type="button" class="btn-close" data-bs-dismiss="alert" aria-label="Close"></button>
                     </div>
                     <h4>Add Sensor</h4>
-                    <form id="add-sensor-form" onsubmit="addSensor(event)">
+                    <form id="add-sensor-form">
                         <div class="mb-3 p-2 border border-1 rounded" id="add-sensor-block">
                             <div class="input-group mb-3">
                                 <span class="input-group-text">Sensor Label</span>
@@ -71,7 +71,7 @@ <h4>Add Sensor</h4>
                         </div>
                     </form>
                     <h4>Configured Sensors</h4>
-                    <form id="aux-form" onsubmit="saveSensors(event)">
+                    <form id="aux-form">
                         <fieldset id="form-fieldset">
 
                         </fieldset>
@@ -85,10 +85,14 @@ <h4>Configured Sensors</h4>
     <script src="frontend/js/firmware.js"></script>
     <script src="frontend/js/bootstrap.bundle.min.js"></script>
     <script type="text/javascript">
+
         loadNavigation();
         loadSensors(true);
         addSensorAddressInputs();
 
+        _("add-sensor-form").addEventListener("onsubmit", addSensor);
+        _("aux-form").addEventListener("onsubmit", saveSensors);
+
         function Sensor() {
             this.Label = "";
             this.IsReturnValue = false;
@@ -163,8 +167,6 @@ <h4>Configured Sensors</h4>
          * */
         function syncSensors() {
             const formElements = _("aux-form").elements;
-            // This will only give us a top-level view of all sensors.
-            const formJson = serializeForm("aux-form");
             sensors.forEach((sensor) => {
                 sensor.Label = formElements[`${sensor.Label}`].value;
                 let radio = _(`${sensor.Label}.use-as-reference`);
@@ -234,7 +236,7 @@ <h4>Configured Sensors</h4>
                 let inputBlockContainer = `
                 <div class="mb-3 p-2 border border-1 rounded" id="${e.Label}-block">
                     <div class="input-group mb-3">
-                        <span for="${e.Label}" class="input-group-text">Sensor Label</span>
+                        <span class="input-group-text">Sensor Label</span>
                         <input
                             name="${e.Label}"
                             type="text"
@@ -247,7 +249,7 @@ <h4>Configured Sensors</h4>
                             <input class="form-check-input mt-0" type="radio"
                             name="use-as-reference" id="${e.Label}.use-as-reference"
                             value="${e.Label}" ${e.IsReturnValue ? "checked" : ""}>
-                            <span class="ms-2" for="${e.Label}.use-as-reference">
+                            <span class="ms-2">
                                 Use as feed return reference
                             </span>
                         </div>
@@ -292,8 +294,6 @@ <h4>Configured Sensors</h4>
             _("config-saving").hidden = false;
             _("save-config-label").innerHTML = "Saving Configuration...";
             _("save-config").disabled = true;
-            // First update the sensors array from form field values
-            const form = _("aux-form").elements;
             syncSensors();
             const isValid = validateSensors();
             console.log(sensors);
diff --git a/data/frontend/canbus.html b/data/frontend/canbus.html
index ed4ce0d..7fecaae 100644
--- a/data/frontend/canbus.html
+++ b/data/frontend/canbus.html
@@ -23,11 +23,11 @@
                     <h3>CAN-Bus Configuration</h3>
                 </div>
                 <div class="row text-start">
-                    <form id="canbus-form" onsubmit="saveCanbusData(event)">
+                    <form id="canbus-form">
                         <fieldset id="form-fieldset">
                             <label class="col-sm-6 col-form-label" for="quartz">CAN-Module Frequency</label>
                             <div class="input-group mb-3">
-                                <input name="quartz" name="quartz" placeholder="Default: 16" type="number" required class="form-control"
+                                <input name="quartz" id="quartz" placeholder="Default: 16" type="number" class="form-control"
                                     autocomplete="quartz" value="16" required>
                                 <span class="input-group-text" id="basic-addon2">MHz</span>
                                 <span id="statusHelpBlock" class="form-text text-muted">Enter the frequency of the quartz (oscillator) which is used
@@ -128,7 +128,7 @@ <h5>Hot Water</h5>
                                 </div>
                                 <div class="input-group mb-3">
                                     <span class="input-group-text col-sm-10" id="lbl.HotWater.Now">Hot Water 'Now' Flag</span>
-                                    <input name="HotWater.Now" maxlength="5" maxlength="5" type="text" class="form-control" placeholder="0x254" aria-label="Hot Water 'Now' Flag"
+                                    <input name="HotWater.Now" maxlength="5" type="text" class="form-control" placeholder="0x254" aria-label="Hot Water 'Now' Flag"
                                         aria-describedby="lbl.HotWater.Now" required>
                                 </div>
                                 <div class="input-group mb-3">
@@ -193,6 +193,8 @@ <h5>Mixed Circuit</h5>
         loadNavigation();
         loadCanAddresses();
 
+        _("canbus-form").addEventListener("onsubmit", saveCanbusData);
+
         async function loadCanAddresses() {
             const form = document.forms["canbus-form"];
             const result = await getConfigJson("/api/config/canbus");
diff --git a/data/frontend/firmware.html b/data/frontend/firmware.html
index 7c558a7..bea3285 100644
--- a/data/frontend/firmware.html
+++ b/data/frontend/firmware.html
@@ -31,7 +31,7 @@ <h3>Update Firmware & Filesystem</h3>
                         </div>
 
                     </div>
-                    <form id="upload_form" enctype="multipart/form-data" method="post" onsubmit="startUpdate(event)">
+                    <form id="upload_form" enctype="multipart/form-data" method="post">
                         <div class="mb-5">
                             <label for="file1" class="form-label">Upload File</label>
                             <input class="form-control" type="file" id="file1" name="file1">
@@ -64,5 +64,7 @@ <h3>Update Firmware & Filesystem</h3>
     <script src="frontend/js/bootstrap.bundle.min.js"></script>
     <script type="text/javascript">
         loadNavigation();
+
+        _("upload_form").addEventListener("onsubmit",startUpdate);
     </script>
 </body>
\ No newline at end of file
diff --git a/data/frontend/general.html b/data/frontend/general.html
index c1a5a9a..4630d50 100644
--- a/data/frontend/general.html
+++ b/data/frontend/general.html
@@ -22,7 +22,7 @@
                     <h3>General Settings</h3>
                 </div>
                 <div class="row">
-                    <form onsubmit="sendGeneralConfig(event)" id="general-form">
+                    <form id="general-form">
                         <fieldset id="form-fieldset">
                         <div class="text-start">
                             <div class="mb-3 row">
@@ -50,7 +50,7 @@ <h3>General Settings</h3>
                                 <label class="col-sm-2 col-form-label" for="busmsgtimeout">Message Timeout</label>
                                 <div class="col-sm-10">
                                     <input id="busmsgtimeout" name="busmsgtimeout" placeholder="Default: 30" type="number"
-                                        required class="form-control" autocomplete="busmsgtimeout" value="30" required>
+                                        class="form-control" autocomplete="busmsgtimeout" value="30" required>
                                         <span id="statusHelpBlock" class="form-text text-muted">Time in seconds before control over the heating is assumed when no other controllers have been detected on the bus.</span>
                                 </div>
                             </div>
@@ -93,6 +93,8 @@ <h3>General Settings</h3>
         getTz();
         loadGeneralConfig();
 
+        _("general-form").addEventListener("onsubmit", sendGeneralConfig);
+
         async function loadGeneralConfig() {
             let form = document.forms["general-form"];
             const config = await getGeneralConfig();
diff --git a/data/frontend/leds.html b/data/frontend/leds.html
index e505736..f3d80bb 100644
--- a/data/frontend/leds.html
+++ b/data/frontend/leds.html
@@ -36,7 +36,7 @@ <h3>LED Configuration</h3>
                             <span class="visually-hidden">Loading...</span>
                         </div>
                     </div>
-                    <form id="led-form" onsubmit="saveConfig(event)">
+                    <form id="led-form">
                         <fieldset id="form-fieldset">
                             <div class="input-group mb-3">
                                 <span class="input-group-text col-sm-9" id="status-led-label">Status LED</span>
@@ -96,6 +96,8 @@ <h3>LED Configuration</h3>
         loadNavigation();
         loadConfig();
 
+        _("led-form").addEventListener("onsubmit", saveConfig);
+
         async function loadConfig() {
             const form = document.forms["led-form"];
             _("form-fieldset").disabled = true;
diff --git a/data/frontend/mqtt.html b/data/frontend/mqtt.html
index 41d17e6..01ba1f1 100644
--- a/data/frontend/mqtt.html
+++ b/data/frontend/mqtt.html
@@ -26,13 +26,13 @@ <h3>MQTT Configuration</h3>
                     <h4>Server Configuration</h4>
                 </div>
                 <div class="row">
-                    <form onsubmit="sendMqttConfig(event)" id="mqtt-form">
+                    <form id="mqtt-form">
                         <div class="text-start">
                             <div class="mb-3 row">
                                 <label class="col-sm-2 col-form-label" for="mqtt-server">Server</label>
                                 <div class="col-sm-10">
                                     <input id="mqtt-server" name="mqtt-server"
-                                        placeholder="The IP address of your MQTT broker" type="text" required
+                                        placeholder="The IP address of your MQTT broker" type="text"
                                         class="form-control" autocomplete="mqtt-server" required>
                                 </div>
                             </div>
@@ -76,7 +76,7 @@ <h4>Server Configuration</h4>
                     <h4>Topics Configuration</h4>
                 </div>
                 <div class="row">
-                    <form onsubmit="sendMqttTopicsConfig(event)" id="mqtt-topics-form">
+                    <form id="mqtt-topics-form">
                         <div class="text-start">
                             <div class="mb-3 row">
                                 <label for="status" class="col-sm-2 col-form-label">Status</label>
@@ -194,6 +194,9 @@ <h4>Topics Configuration</h4>
         loadMqttConfig();
         loadMqttTopicsConfig();
 
+        _("mqtt-form").addEventListener("onsubmit", sendMqttConfig);
+        _("mqtt-topics-form").addEventListener("onsubmit", sendMqttTopicsConfig);
+
         async function loadMqttConfig() {
             const form = document.forms["mqtt-form"];
             form.disabled = true;
diff --git a/data/frontend/reboot.html b/data/frontend/reboot.html
index d6a0de6..25c5f61 100644
--- a/data/frontend/reboot.html
+++ b/data/frontend/reboot.html
@@ -10,23 +10,26 @@
 </head>
 
 <body>
+<div class="container-fluid text-center">
     <div class="alert alert-secondary" role="alert">
         Rebooting, returning to main page in <span class="badge text-bg-primary" id="countdown">30</span> seconds
     </div>
-    <script type="text/javascript">
-        let seconds = 20;
+</div>
+<script type="text/javascript">
+    let seconds = 30;
 
-        function countdown() {
-            seconds = seconds - 1;
-            if (seconds < 0) {
-                window.location = "/";
-            } else {
-                document.getElementById("countdown").innerHTML = seconds;
-                window.setTimeout("countdown()", 1000);
-            }
+    function countdown() {
+        seconds = seconds - 1;
+        if (seconds < 0) {
+            window.location = "/";
+        } else {
+            document.getElementById("countdown").innerHTML = seconds;
+            window.setTimeout("countdown()", 1000);
         }
-        countdown();
-    </script>
+    }
+
+    countdown();
+</script>
 </body>
 
 </html>
\ No newline at end of file
diff --git a/data/frontend/wifi.html b/data/frontend/wifi.html
index 5a8418e..df9eeaf 100644
--- a/data/frontend/wifi.html
+++ b/data/frontend/wifi.html
@@ -22,7 +22,7 @@
                     <h3>Set Wifi Credentials</h3>
                 </div>
                 <div class="row">
-                    <form onsubmit="sendWifiConfig(event)" id="wifi-form">
+                    <form id="wifi-form">
                         <fieldset id="form-fieldset">
                         <div class="text-start">
                             <div class="mb-3 row">
@@ -86,7 +86,9 @@ <h3>Found Networks</h3>
         loadNavigation();
     </script>
     <script type="text/javascript">        
-        loadWifiConfig();     
+        loadWifiConfig();
+
+        _("wifi-form").addEventListener("onsubmit", sendWifiConfig);
 
         async function loadWifiConfig()
         {

From 1132d9c73d4b694f9eefd9ca263c1755540295b3 Mon Sep 17 00:00:00 2001
From: Neuroquila-n8fall <david.ginsbach@googlemail.com>
Date: Fri, 7 Oct 2022 09:24:41 +0200
Subject: [PATCH 10/14] Show actual CAN error on UI instead of counting
 messages that have not been delivered.

---
 data/frontend/index.html      |  5 +++--
 data/frontend/js/framework.js | 18 ++++++++++++++++++
 include/can_processor.h       |  3 +++
 src/can_processor.cpp         | 10 ++++++----
 src/webconfig.cpp             |  2 +-
 5 files changed, 31 insertions(+), 7 deletions(-)

diff --git a/data/frontend/index.html b/data/frontend/index.html
index afaf7de..61377bf 100644
--- a/data/frontend/index.html
+++ b/data/frontend/index.html
@@ -116,8 +116,9 @@ <h3>System Status</h3>
                 _("prog-sketch").setAttribute('aria-valuenow', occupiedSketchPercent);
                 _("prog-sketch").innerHTML = `${Math.round(occupiedSketchPercent)}%`;
                 _("sketch").innerHTML = `${humanReadableSize(status["sketchsize"])} out of ${humanReadableSize(status["freesketch"])} used`;
-                _("can").innerHTML = status["canstatus"] ? "Working" : "Error";
-                if(status["canstatus"]) {
+                let canStatus = status["canstatus"];
+                _("can").innerHTML = CanErrorCodes[canStatus];
+                if(canStatus === 0) {
                     _("can").classList.remove("bg-danger");
                     _("can").classList.add("bg-success");
                 } else {
diff --git a/data/frontend/js/framework.js b/data/frontend/js/framework.js
index 0ea584f..8da678a 100644
--- a/data/frontend/js/framework.js
+++ b/data/frontend/js/framework.js
@@ -2,6 +2,24 @@ function _(el) {
     return document.getElementById(el);
 }
 
+const CanErrorCodes = [
+    "OK",
+    "No MCP2515",
+    "Too Far From Desired Bit Rate",
+    "Inconsistent Bit Rate Settings",
+    "INT Pin Is Not An Interrupt",
+    "ISR Is Null",
+    "Requested Mode TimeOut",
+    "Acceptance Filter Array Is NULL",
+    "One Filter Mask Requires One Or Two Acceptance Filters",
+    "Two Filter Masks Require Three To Six Acceptance Filters",
+    "Cannot Allocate Receive Buffer",
+    "Cannot Allocate Transmit Buffer 0",
+    "Cannot Allocate Transmit Buffer 1",
+    "Cannot Allocate Transmit Buffer 2",
+    "ISR Not Null And No Int Pin",
+]
+
 function humanReadableSize(bytes) {
     if (bytes < 1024)
         return bytes + " B";
diff --git a/include/can_processor.h b/include/can_processor.h
index 19b1aca..5777b7a 100644
--- a/include/can_processor.h
+++ b/include/can_processor.h
@@ -4,6 +4,9 @@
 #include <Arduino.h>
 #include <ACAN2515.h>
 
+//-- CAN-Library Configuration Error code
+extern volatile uint16_t CanConfigErrorCode;
+
 //——————————————————————————————————————————————————————————————————————————————
 //  MCP2515 Driver object
 //——————————————————————————————————————————————————————————————————————————————
diff --git a/src/can_processor.cpp b/src/can_processor.cpp
index 088dd37..9587dd0 100644
--- a/src/can_processor.cpp
+++ b/src/can_processor.cpp
@@ -23,6 +23,8 @@ static const byte MCP2515_SCK = 18;  // SCK input of MCP2515
 static const byte MCP2515_MOSI = 23; // SDI input of MCP2515
 static const byte MCP2515_MISO = 19; // SDO output of MCP2515
 
+volatile uint16_t CanConfigErrorCode;
+
 ACAN2515 can(MCP2515_CS, SPI, MCP2515_INT);
 
 double temp = 0.00F;
@@ -55,9 +57,9 @@ void setupCan()
   uint32_t frequency = configuration.CanModuleConfig.CAN_Quartz * 1000UL * 1000UL; // 16 MHz
   ACAN2515Settings settings(frequency, 10UL * 1000UL); // CAN bit rate 10 kb/s
 
-  const uint16_t errorCode = can.begin(settings, []
+  CanConfigErrorCode = can.begin(settings, []
                                        { can.isr(); });
-  if (errorCode == 0 && configuration.General.Debug)
+  if (CanConfigErrorCode == 0 && configuration.General.Debug)
   {
     Log.print("Bit Rate prescaler: ");
     Log.println(settings.mBitRatePrescaler);
@@ -80,10 +82,10 @@ void setupCan()
     Log.print(settings.samplePointFromBitStart());
     Log.println("%");
   }
-  if (errorCode != 0)
+  if (CanConfigErrorCode != 0)
   {
     Log.print("Configuration error 0x");
-    Log.println(errorCode, HEX);
+    Log.println(CanConfigErrorCode, HEX);
   }
 }
 
diff --git a/src/webconfig.cpp b/src/webconfig.cpp
index 9a96d2c..69e2d82 100644
--- a/src/webconfig.cpp
+++ b/src/webconfig.cpp
@@ -921,7 +921,7 @@ void getSystemStatus(AsyncWebServerRequest *request)
     doc["heap"] = ESP.getHeapSize();
     doc["freesketch"] = ESP.getFreeSketchSpace();
     doc["sketchsize"] = ESP.getSketchSize();
-    doc["canstatus"] = CanSendErrorCount == 0;
+    doc["canstatus"] = CanConfigErrorCode;
     doc["canerrorcount"] = CanSendErrorCount;
     doc["mqtt"] = client.connected();
 

From 33cf7faaef89d24951dd03321c547f7a2c84febe Mon Sep 17 00:00:00 2001
From: Neuroquila-n8fall <david.ginsbach@googlemail.com>
Date: Fri, 7 Oct 2022 09:40:34 +0200
Subject: [PATCH 11/14] Highlight CAN errors

---
 data/frontend/index.html | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/data/frontend/index.html b/data/frontend/index.html
index 61377bf..971720e 100644
--- a/data/frontend/index.html
+++ b/data/frontend/index.html
@@ -125,7 +125,15 @@ <h3>System Status</h3>
                     _("can").classList.remove("bg-success");
                     _("can").classList.add("bg-danger");
                 }
-                _("canerrorcount").innerHTML = status["canerrorcount"];
+                let canErrorCount = status["canerrorcount"];
+                _("canerrorcount").innerHTML = canErrorCount;
+                if(canErrorCount === 0) {
+                    _("canerrorcount").classList.remove("bg-danger");
+                    _("canerrorcount").classList.add("bg-success");
+                } else {
+                    _("canerrorcount").classList.remove("bg-success");
+                    _("canerrorcount").classList.add("bg-danger");
+                }
                 _("mqtt").innerHTML = status["mqtt"] ? "Connected" : "Disconnected";
                 if(status["mqtt"]) {
                     _("mqtt").classList.remove("bg-danger");

From 37f65532b04ee8759fde3c32a0af5750c93a2fe6 Mon Sep 17 00:00:00 2001
From: Neuroquila-n8fall <david.ginsbach@googlemail.com>
Date: Fri, 7 Oct 2022 09:40:58 +0200
Subject: [PATCH 12/14] Rename field to reflect actual use

---
 data/frontend/index.html | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/data/frontend/index.html b/data/frontend/index.html
index 971720e..bcfa34f 100644
--- a/data/frontend/index.html
+++ b/data/frontend/index.html
@@ -50,7 +50,7 @@ <h3>System Status</h3>
                             <span class="badge bg-primary rounded-pill" id="sketch"></span>
                         </li>
                         <li class="list-group-item d-flex justify-content-between align-items-center">
-                            CAN-Bus Status
+                            CAN-Bus Module
                             <span class="badge bg-primary rounded-pill" id="can"></span>
                         </li>
                         <li class="list-group-item d-flex justify-content-between align-items-center">

From 1b39e0e55a9a239892f59ceaa6bb6d5ec4233a37 Mon Sep 17 00:00:00 2001
From: Neuroquila-n8fall <david.ginsbach@googlemail.com>
Date: Fri, 7 Oct 2022 09:41:15 +0200
Subject: [PATCH 13/14] Introduce delay so redirect works

---
 src/main.cpp | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/src/main.cpp b/src/main.cpp
index ed0933e..c74ffde 100644
--- a/src/main.cpp
+++ b/src/main.cpp
@@ -148,6 +148,8 @@ void loop()
 {
   // Init reboot if requested
   if (ShouldReboot) {
+    // Wait a bit so the client is redirected properly...
+    vTaskDelay(3000 / portTICK_PERIOD_MS);
     WiFi.disconnect();
     server->end();
     vTaskDelay(3000 / portTICK_PERIOD_MS);

From d86ad8350b6a520e0e04df3a4744ba472ef468b3 Mon Sep 17 00:00:00 2001
From: Neuroquila-n8fall <david.ginsbach@googlemail.com>
Date: Fri, 7 Oct 2022 10:14:23 +0200
Subject: [PATCH 14/14] Create Changelog

---
 Changelog.md | 193 +++++++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 193 insertions(+)
 create mode 100644 Changelog.md

diff --git a/Changelog.md b/Changelog.md
new file mode 100644
index 0000000..7f1f606
--- /dev/null
+++ b/Changelog.md
@@ -0,0 +1,193 @@
+# Changelog
+
+## v0.9.2
+Some fixes and improvements have been made.
+For example the Reboot button didn't actually reboot the system.
+
+Also the status page will now reflect the actual error state of the CAN-module instead of just counting erroneous messages.
+
+A few code style errors have been fixed and some deprecated code snippets replaced.
+
+## v0.9.1
+This release contains a much needed enhancement to the user friendliness.
+The integrated web interface allows you to:
+- View overall system status
+- Manage files (i.e. download your configuration and upload it again)
+- Upload firmware and filesystem images so you don't have to spin up Platformio everytime there is a new release.
+- Configure everything via forms instead of dealing with a json file
+- Watch CAN messages on your bus with automatic value change highlighting. This will help you identify new message types without having to spin up a full blown CAN analyzer.
+
+### Install Instructions
+- Upload firmware
+- Upload filesystem
+- Open the Web UI @ http://cerasmarter/
+- Configure everything to your needs
+
+
+### REST Api
+
+With the addition of a web UI a REST Api has been introduced. You can query via GET on the endpoints to receive the currently active config or POST to store the config.
+
+The Endpoints are located at:
+/api/config
+- /general
+```json
+{
+  "heatingvalues": true,
+  "watervalues": false,
+  "auxvalues": true,
+  "tz": "Europe/Berlin",
+  "busmsgtimeout": 30,
+  "debug": true,
+  "sniffing": true
+}
+```
+- /wifi
+```json
+{
+  "wifi_ssid": "ssid",
+  "wifi_pw": "",
+  "hostname": "CERASMARTER"
+}
+```
+- /canbus
+```json
+{
+  "Controller": {
+    "FlameStatus": "0x209",
+    "Error": "0x206",
+    "DateTime": "0x256"
+  },
+  "Heating": {
+    "FeedCurrent": "0x201",
+    "FeedMax": "0x200",
+    "FeedSetpoint": "0x252",
+    "OutsideTemperature": "0x207",
+    "Pump": "0x20A",
+    "Season": "0x20C",
+    "Operation": "0x250",
+    "Power": "0x251",
+    "Mode": "0x258",
+    "Economy": "0x253"
+  },
+  "HotWater": {
+    "SetpointTemperature": "0x203",
+    "MaxTemperature": "0x204",
+    "CurrentTemperature": "0x205",
+    "Now": "0x254",
+    "BufferOperation": "0x20B",
+    "ContinousFlow": {
+      "SetpointTemperature": "0x255"
+    }
+  },
+  "MixedCircuit": {
+    "Pump": "0x404",
+    "FeedSetpoint": "0x405",
+    "FeedCurrent": "0x440",
+    "Economy": "0x407"
+  }
+}
+```
+- /leds
+```json
+{
+  "wifi-led": 26,
+  "status-led": 27,
+  "mqtt-led": 14,
+  "heating-led": 25
+}
+```
+- /mqtt
+```json
+{
+  "mqtt-server": "1.2.3.4",
+  "mqtt-port": 1883,
+  "mqtt-user": "mqtt",
+  "mqtt-password": "mqtt"
+}
+```
+- /auxsensors
+```json
+[
+  [
+    {
+      "Label": "Feed",
+      "IsReturnValue": false,
+      "Address": [
+        "0x28",
+        "0x76",
+        "0x51",
+        "0x91",
+        "0x42",
+        "0x20",
+        "0x01",
+        "0xE3"
+      ]
+    },
+    {
+      "Label": "Return",
+      "IsReturnValue": true,
+      "Address": [
+        "0x28",
+        "0x6F",
+        "0x9C",
+        "0xF6",
+        "0x42",
+        "0x20",
+        "0x01",
+        "0xF6"
+      ]
+    },
+    {
+      "Label": "Exhaust",
+      "IsReturnValue": false,
+      "Address": [
+        "0x28",
+        "0x6D",
+        "0x98",
+        "0xF5",
+        "0x42",
+        "0x20",
+        "0x01",
+        "0x0F"
+      ]
+    },
+    {
+      "Label": "Ambient",
+      "IsReturnValue": false,
+      "Address": [
+        "0x28",
+        "0xBF",
+        "0x39",
+        "0x10",
+        "0x42",
+        "0x20",
+        "0x01",
+        "0x93"
+      ]
+    }
+  ]
+]
+```
+
+## v0.9.0
+Not only I noticed that it's about time to optimize the heating system. Thanks to the input of @rejoe2 we were able to simplify things so it can be adopted by a broader audience!
+
+This release is all about making things easier. No longer is it necessary to modify code to get this working. You only need VS Code, the Platformio extension and you're (mostly) good to go!
+
+Previously I considered this project a PoC (Proof of Concept) - a foundation for others to build their own system on.
+
+Please let us know if anything should be broken or you got trouble making it work.
+
+Instructions for this release:
+- See Readme for prerequisites
+- Build firmware and filesystem images
+- Upload firmware to ESP32
+- Modify the configuration so it fits your environment
+- Upload filesystem image to ESP
+
+## What's Changed
+* Merge Feature and Optimization Overhaul by @Neuroquila-n8fall in https://github.com/Neuroquila-n8fall/JunkersControl/pull/7
+
+
+**Full Changelog**: https://github.com/Neuroquila-n8fall/JunkersControl/commits/v0.9.0