Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Metrics Upgrades #226

Open
jasonlyik opened this issue Jul 17, 2024 · 2 comments
Open

Metrics Upgrades #226

jasonlyik opened this issue Jul 17, 2024 · 2 comments
Labels
metric

Comments

@jasonlyik
Copy link
Contributor

jasonlyik commented Jul 17, 2024 •
edited
Loading

Running issue for metrics upgrades:

Increasing unittest coverage:

  • Tests for synops LSTMCell, RNNCell, GRUCell should include batch size > 1

Features / Modularization:

  • Connection sparsity pull out long if/elif statement to separate functions
  • Hooks are only added specifically for the metrics that need them
@jasonlyik jasonlyik changed the title Metrics Unittests Metrics Upgrades Jul 17, 2024
@ben9809
Copy link
Contributor

ben9809 commented Aug 14, 2024

@SreyesVenkatesh, @jasonlyik I found this codecov.io tool to give a better overview of the code covered by the unit tests. Once implemented it will be beneficial to extend our unit tests.

@ben9809
Copy link
Contributor

ben9809 commented Aug 14, 2024

https://app.codecov.io/gh/NeuroBench/neurobench
Here you can find the report

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
metric
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ben9809 @jasonlyik