Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

data/GeopoliticalUnits default resolution #47

Open
stryker-m opened this issue Oct 9, 2017 · 2 comments
Open

data/GeopoliticalUnits default resolution #47

stryker-m opened this issue Oct 9, 2017 · 2 comments

Comments

@stryker-m
Copy link
Contributor

v1 returns continents and countries. v2 returns many more units
@SimonGoring
Copy link
Contributor

There is a rank parameter in the new geopoliticalunits endpoint, using rank-=1 limits results to countries/continents. Do we need to set a default, or is it enough to indicate the use of the rank parameter?

@stryker-m
Copy link
Contributor Author

You can leave it as is for v2. If we target v1.5 as the first published API following the migration, then a default for v1.5 is needed to match v1. We could go case by case to see how adverse the impact of changes are on Explorer. I'd rather go by the rule: endpoint and output need to match.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@SimonGoring @stryker-m