Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unused Embedding Layer in KimCNN #1

Open
jvcop opened this issue Feb 6, 2020 · 1 comment
Open

Unused Embedding Layer in KimCNN #1

jvcop opened this issue Feb 6, 2020 · 1 comment

Comments

@jvcop
Copy link

jvcop commented Feb 6, 2020

First of all thanks for providing this interesting notebook :)

I might be overlooking something, but it seems the embedding layer in KimCNN is unused.
@hxtkyne
Copy link

hxtkyne commented May 25, 2020

yes，you are right. You can remove it because it's not useful for the project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jvcop @hxtkyne