Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Fail to patch CCCL in versions.json #2582

Open
ttnghia opened this issue Nov 8, 2024 · 2 comments
Open

[BUG] Fail to patch CCCL in versions.json #2582

ttnghia opened this issue Nov 8, 2024 · 2 comments
Assignees
Labels
bug Something isn't working build

Comments

@ttnghia
Copy link
Collaborator

ttnghia commented Nov 8, 2024

When compiling spark-rapids-jni, patching CCCL is faling:

[INFO]      [exec] -- rapids-cmake [CCCL]: failed to apply diff cccl_symbol_visibility.diff
[INFO]      [exec] -- rapids-cmake [CCCL]: git diff output: error: can't open patch 'jni/thirdparty/cudf-pins/cccl_symbol_visibility.diff': No such file or directory
[INFO]      [exec] -- 
[INFO]      [exec] -- rapids-cmake [CCCL]: failed to apply diff thrust_disable_64bit_dispatching.diff
[INFO]      [exec] -- rapids-cmake [CCCL]: git diff output: error: can't open patch 'jni/thirdparty/cudf-pins/thrust_disable_64bit_dispatching.diff': No such file or directory
[INFO]      [exec] -- 
[INFO]      [exec] -- rapids-cmake [CCCL]: failed to apply diff thrust_faster_sort_compile_times.diff
[INFO]      [exec] -- rapids-cmake [CCCL]: git diff output: error: can't open patch 'jni/thirdparty/cudf-pins/thrust_faster_sort_compile_times.diff': No such file or directory
[INFO]      [exec] -- 
[INFO]      [exec] -- rapids-cmake [CCCL]: failed to apply diff thrust_faster_scan_compile_times.diff
[INFO]      [exec] -- rapids-cmake [CCCL]: git diff output: error: can't open patch 'jni/thirdparty/cudf-pins/thrust_faster_scan_compile_times.diff': No such file or directory

Without patching, the build still proceeds successfully but there may be potential issues with the built binary due to non-patching CCCL.

@ttnghia ttnghia added ? - Needs Triage bug Something isn't working labels Nov 8, 2024
@pxLi
Copy link
Collaborator

pxLi commented Nov 12, 2024

${current_json_dir} is evaluated at runtime and points to the directory holding the pinned versions.json file https://github.com/rapidsai/rapids-cmake/blob/branch-24.12/rapids-cmake/cpm/detail/generate_patch_command.cmake#L61

which actually should target the cudf path in our case https://github.com/rapidsai/cudf/tree/branch-24.12/cpp/cmake/thirdparty/patches

We may need to move the patches from cudf folder into cudf-pins/ or replace the var ${current_json_dir} during submodule-sync

@pxLi pxLi self-assigned this Nov 12, 2024
@jlowe
Copy link
Member

jlowe commented Nov 12, 2024

@robertmaynard this appears to be a bug in the rapids-cmake code that generates versions.json when patch files are referenced for a dependency. It's using ${current_json_dir}/ for the patch file locations, when they are not co-located with versions.json. Seems like ${current_json_dir} should be expanded, per dependency, when emitting this file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working build
Projects
None yet
Development

No branches or pull requests

4 participants