Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA] Limit symbol visibility in shared library #2151

Open
jlowe opened this issue Jun 17, 2024 · 0 comments
Open

[FEA] Limit symbol visibility in shared library #2151

jlowe opened this issue Jun 17, 2024 · 0 comments
Labels

Comments

@jlowe
Copy link
Member

jlowe commented Jun 17, 2024

Is your feature request related to a problem? Please describe.
Currently the native build exports all symbols in the shared library. We should only be exporting symbols that are part of our API to avoid non-API usage and accidental conflicts with dependencies pulled in with other shared libraries (e.g.: spdlog).

Describe the solution you'd like
We should be limiting symbols to those that are explicitly exported. See rapidsai/cudf#15982 for how RAPIDS is doing this in cudf.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants