Fix defines all over the place. #268
blockhead100
started this conversation in
Ideas
Replies: 1 comment
-
In general, nvlimits.h is intended to be the source of truth: it should have no dependencies on anything else. Sure, it seems reasonable to me to delete NV_MAX_GPUs and have its current users include nvlimits.h and use NV_MAX_DEVICES instead. Do you have other examples? We probably should handle on a case-by-case basis. |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
There are lots of #define all over like in nv-gpu-info.h where there is a #define NV_MAX_DEVICES 32 and in nvlimits.h it defines it again.
Should this be fixed?
Beta Was this translation helpful? Give feedback.
All reactions