Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backends need to be reworked to be opt-in at cmake config time #2363

Open
schweitzpgi opened this issue Nov 7, 2024 · 0 comments
Open

Backends need to be reworked to be opt-in at cmake config time #2363

schweitzpgi opened this issue Nov 7, 2024 · 0 comments
Assignees

Comments

@schweitzpgi
Copy link
Collaborator

schweitzpgi commented Nov 7, 2024

With the Braket backend:

The prerequisite repos and packages should be downloaded and built as part of the prereq build and install script and not part of the tpls/ directory tree. These files are not required by any other backend. The current integration is downloading these repos and their submodules and trying (unsuccessfully in general) to configure and build them as a cmake configuration step at project build time. Since not every build will want (or can) build the Braket backend this latter approach doesn't really work.

See PR 2362 for an initial draft that removes the submodule and adds a CMake variable to allow the inclusion of the Braket backend under user control. This PR is incomplete: the CI will require changes to the build scripts to enable the Braket backend for testing, etc. Also the tests specifically tailored for the Braket backend must be updated to use REQUIRES: bracket or some such configuration setting for developer builds and builds in other ad hoc environments.

Looking through the cmake files, some of the targets are opt-in and some of them are hardcoded to always get built. We should be more rigorous here and have the default backend built by default and the other backends selectable via cmake command line variables. This structure will provide the greatest portability for tool builders and end-users.

@schweitzpgi schweitzpgi changed the title The Braket backend needs to be reworked Backends need to be reworked to be opt-in at cmake config time Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants