Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retire text_bytes_aware_shuffle and directly use shuffle #240

Open
VibhuJawa opened this issue Sep 10, 2024 · 1 comment · May be fixed by #316
Open

Retire text_bytes_aware_shuffle and directly use shuffle #240

VibhuJawa opened this issue Sep 10, 2024 · 1 comment · May be fixed by #316
Assignees

Comments

@VibhuJawa
Copy link
Collaborator

VibhuJawa commented Sep 10, 2024

We should retire text_bytes_aware_shuffle as we have #77 merged in now .

That will mean we refactor below code .

try:
# NOTE: If we have more text-df partitions than bucket-map
# partitions, we are more likely to see an OverflowError
output_df = text_bytes_aware_shuffle(
df=merge_left_to_shuffled_right(
subset_text_df,
subset_bucket_df,
merge_on,
),
partition_on=partition_on,
text_column=self.text_field,
num_workers=num_workers,
)
except OverflowError as err:
# We encountered an overflow error!
# Let's try again with less text data
parts_per_text_batch_retry = int(parts_per_text_batch_use / 2)
if parts_per_text_batch_retry < 1:
raise err
print(
f"\nWe encountered an OverflowError and will retry "
f"the current batch with {parts_per_text_batch_retry} "
f"text partitions instead of {parts_per_text_batch_use}.",
flush=True,
)
continue

Update 10/28

We have WIP PR #316 however we noticed a performance regression (10-20% slower at scale). Fixing it the right way will require more investigation which means I'll put this at risk for this release (slack thread).

Update 11/04

Working on it this week in #316

@VibhuJawa
Copy link
Collaborator Author

CC: @ayushdg

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants