Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BEL Demo Throws Error When Power Trace Cannot Be Met #97

Open
SWRIganderson opened this issue Nov 4, 2024 · 3 comments
Open

BEL Demo Throws Error When Power Trace Cannot Be Met #97

SWRIganderson opened this issue Nov 4, 2024 · 3 comments

Comments

@SWRIganderson
Copy link
Collaborator

@calbaker If you make a power trace that the BEL cannot achieve, the demo fails. While I think this is the right behavior, I also think we need an alternative mode of operation. We need to let the BEL not achieve the power trace and potentially be deadweight on the train. This would allow someone to feed the model data from an event recorder and figure out how a BEL would perform on many different routes using ALTRIOS. I looked into what it would take to change this in the rust code, but I couldn't quite put my finger on where to start. I believe changes are needed in the locomotive and reversible energy storage rust code.

@garrettlanderson
Copy link

@calbaker see the file attached to this comment. I was having trouble with git authentication on the computer I did this on. All I did was multiple the time by 100 on the power trace. It runs out of batteries. Let me know if you think I could fix this with a little direction.

bel_demo.py.txt

image

@SWRIganderson
Copy link
Collaborator Author

@calbaker Could you take a look at the example I added with commit 367fd5d. This is what I used to make the slides last week. What I don't like is how it is structured. I would like some suggestions on how to get this structured in a manner that is similar to the other examples. The stuff I created to make the power trace from notches is useful, but I feel like it should maybe be tucked away somewhere else in the framework. I also need to add a filter to it so that notches are not step changes, but it worked well enough to get some data created to demonstrate the concept.

@SWRIganderson
Copy link
Collaborator Author

@calbaker did you see my comment on the pull request about making the argument optional? I was curious if you had any thoughts about that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants