You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
At this time of this issue, GHEDisgner has the following:
Near-Square
Rectangle
Bi-Rectangle
Bi-Zoned Rectangle
Bi-Rectangle Constrained
Rowwise
The last two require the input of property boundaries, which can now be pulled from GeoJSON geometry now that this PR has been merged.
At the time of this issue being opened, ThermalNetwork only supports "Rectangle" if ghe_geometric_params are assigned to a given GHE in the system parameter JSON like so:
.. or it can use "Bi-Rectangle Constrained" if no ghe_geometric_params are assigned.
The schema should probably be expanded to offer the other different types of ghe_geometric_params and maybe a method key should be added, similar to how GHEDesigner's native schema works (see the link to the GHEDesigner docs above).
As noted in the GHE Designer docs below, there are a range of different geometric constraints that can be used for borehole placement:
https://ghedesigner.readthedocs.io/en/latest/schemas.html#geometric-constraint-input-schemas
At this time of this issue, GHEDisgner has the following:
The last two require the input of property boundaries, which can now be pulled from GeoJSON geometry now that this PR has been merged.
At the time of this issue being opened, ThermalNetwork only supports "Rectangle" if
ghe_geometric_params
are assigned to a given GHE in the system parameter JSON like so:.. or it can use "Bi-Rectangle Constrained" if no
ghe_geometric_params
are assigned.The schema should probably be expanded to offer the other different types of
ghe_geometric_params
and maybe amethod
key should be added, similar to how GHEDesigner's native schema works (see the link to the GHEDesigner docs above).Along with this, the older
geometric_constraints
that apply to all of the GHE's should probably be removed so that each GHE can use a different geometric constraint option (if desired). So this part of the sample system parameter would get removed:https://github.com/NREL/ThermalNetwork/blob/main/demos/sdk_output_skeleton_1_ghe/run/baseline_scenario/ghe_dir/sys_params.json#L120-L126
... and shifted to the
ghe_specific_params
.After all of this is done, a PR would have to be sent to the geojson-modelica-translator to update the system parameter schema with the changes.
The text was updated successfully, but these errors were encountered: