Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support More (or All) of GHEDesigner's Geometric Constraint Options #48

Open
chriswmackey opened this issue Nov 14, 2024 · 0 comments
Open
Labels
enhancement New feature or request

Comments

@chriswmackey
Copy link
Collaborator

As noted in the GHE Designer docs below, there are a range of different geometric constraints that can be used for borehole placement:

https://ghedesigner.readthedocs.io/en/latest/schemas.html#geometric-constraint-input-schemas

At this time of this issue, GHEDisgner has the following:

  • Near-Square
  • Rectangle
  • Bi-Rectangle
  • Bi-Zoned Rectangle
  • Bi-Rectangle Constrained
  • Rowwise

The last two require the input of property boundaries, which can now be pulled from GeoJSON geometry now that this PR has been merged.

At the time of this issue being opened, ThermalNetwork only supports "Rectangle" if ghe_geometric_params are assigned to a given GHE in the system parameter JSON like so:

"ghe_geometric_params": {
  "length_of_ghe": 232.52683597088145,
  "width_of_ghe": 157.97316402911855
}

.. or it can use "Bi-Rectangle Constrained" if no ghe_geometric_params are assigned.

The schema should probably be expanded to offer the other different types of ghe_geometric_params and maybe a method key should be added, similar to how GHEDesigner's native schema works (see the link to the GHEDesigner docs above).

Along with this, the older geometric_constraints that apply to all of the GHE's should probably be removed so that each GHE can use a different geometric constraint option (if desired). So this part of the sample system parameter would get removed:
https://github.com/NREL/ThermalNetwork/blob/main/demos/sdk_output_skeleton_1_ghe/run/baseline_scenario/ghe_dir/sys_params.json#L120-L126
... and shifted to the ghe_specific_params.

After all of this is done, a PR would have to be sent to the geojson-modelica-translator to update the system parameter schema with the changes.

@chriswmackey chriswmackey added the enhancement New feature or request label Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant