Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dis-ambiguate method names between TN & GHED #22

Open
vtnate opened this issue Mar 15, 2024 · 0 comments
Open

Dis-ambiguate method names between TN & GHED #22

vtnate opened this issue Mar 15, 2024 · 0 comments
Assignees
Labels
ignore for release This shouldn't be included in automatic changelog

Comments

@vtnate
Copy link
Collaborator

vtnate commented Mar 15, 2024

Is your feature request related to a problem? Please describe.
We write our own method called set_design, and we also use a method from GHED called set_design (which is called here in TN). Those confused me until I paid closer attention to the namespaces and figured out they were from different packages.

Describe the solution you'd like
Rename the ThermalNetwork method

Describe alternatives you've considered
The code works, we could just leave it alone.

Additional context
Add any other context or screenshots about the feature request here.

@vtnate vtnate added the ignore for release This shouldn't be included in automatic changelog label Mar 15, 2024
@vtnate vtnate self-assigned this Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ignore for release This shouldn't be included in automatic changelog
Projects
None yet
Development

No branches or pull requests

1 participant