Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing bug on PTDF calculation with distributed slack #47

Merged
merged 11 commits into from
Aug 2, 2023

Conversation

alefcastelli
Copy link
Contributor

Thanks for opening a PR to PowerNetworkMatrices.jl, please take note of the following when making a PR:

Check the contributor guidelines

test/test_ptdf.jl Outdated Show resolved Hide resolved
test/test_ptdf.jl Outdated Show resolved Hide resolved
test/test_ptdf.jl Outdated Show resolved Hide resolved
@github-actions
Copy link
Contributor

github-actions bot commented Jul 31, 2023

Performance Results

Version Precompile Time
Main 3.307908356
This Branch 3.167877621
Version Execute Time
Main-Build PTDF First 7.713823033
Main-Build PTDF Second 0.225342885
Main-Build Ybus First 0.478345355
Main-Build Ybus Second 0.011046494
Main-Build LODF First 0.681073316
Main-Build LODF Second 0.351613654
This Branch-Build PTDF First 7.868789957
This Branch-Build PTDF Second 0.231680325
This Branch-Build Ybus First 0.498887552
This Branch-Build Ybus Second 0.010603107
This Branch-Build LODF First 0.691923537
This Branch-Build LODF Second 0.36438412

@jd-lara
Copy link
Member

jd-lara commented Aug 1, 2023

@alefcastelli the code looks ok to me but there is a mistake in the test that uses the wrong keyword argument

test/test_ptdf.jl Outdated Show resolved Hide resolved
test/test_ptdf.jl Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Aug 1, 2023

Codecov Report

Merging #47 (c4dde3f) into main (82c5591) will increase coverage by 1.74%.
The diff coverage is 78.57%.

❗ Current head c4dde3f differs from pull request most recent head 4841224. Consider uploading reports for the commit 4841224 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #47      +/-   ##
==========================================
+ Coverage   70.27%   72.02%   +1.74%     
==========================================
  Files          14       14              
  Lines        1006     1008       +2     
==========================================
+ Hits          707      726      +19     
+ Misses        299      282      -17     
Flag Coverage Δ
unittests 72.02% <78.57%> (+1.74%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/ptdf_calculations.jl 86.25% <78.57%> (+11.09%) ⬆️

... and 1 file with indirect coverage changes

@jd-lara jd-lara self-requested a review August 2, 2023 06:21
@jd-lara jd-lara enabled auto-merge August 2, 2023 06:22
@jd-lara jd-lara merged commit 79a1694 into main Aug 2, 2023
7 checks passed
@jd-lara jd-lara deleted the fixing_distributed_slack branch August 23, 2023 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants