You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
A year ago, a set of changes fixing build errors, removing the need for ITKv3 compatibility and ITKDeprecated, modernizing the build-system and streamlining the integration of niral_utitlies in project like Slicer was proposed by @jcfr and integrated by @styner. For reference, the full list of changes is reported below.
It turns out that 4a841de introduced a regression and inadvertently removed niral_utilitiesConfig.cmake file.
Thanks to @juanprietob and the version control history, the issue was fixed in 47d38ac
Proposed solution
To avoid such issue from happening, I suggest to setup continuous integration for this project. A possible approach would be to use CircleCI to build the project, execute test and also try to configure a simple project using find_package(niral_utitlies REQUIRED)
Full list of changes
5946726 - README: Improve readbility of module listing
4a841de - COMP: Update minimum required CMake version to match Slicer requirements
The text was updated successfully, but these errors were encountered:
jcfr
changed the title
Prevent build-system regression setting up continus integration
Prevent build-system regression setting up continuous integration
Aug 14, 2018
Summary
A year ago, a set of changes fixing build errors, removing the need for ITKv3 compatibility and
ITKDeprecated
, modernizing the build-system and streamlining the integration ofniral_utitlies
in project like Slicer was proposed by @jcfr and integrated by @styner. For reference, the full list of changes is reported below.It turns out that 4a841de introduced a regression and inadvertently removed
niral_utilitiesConfig.cmake
file.Thanks to @juanprietob and the version control history, the issue was fixed in 47d38ac
Proposed solution
To avoid such issue from happening, I suggest to setup continuous integration for this project. A possible approach would be to use CircleCI to build the project, execute test and also try to configure a simple project using
find_package(niral_utitlies REQUIRED)
Full list of changes
The text was updated successfully, but these errors were encountered: