Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

General Code Review #15

Open
5 tasks
martialblog opened this issue Nov 15, 2024 · 1 comment
Open
5 tasks

General Code Review #15

martialblog opened this issue Nov 15, 2024 · 1 comment

Comments

@martialblog
Copy link
Member

martialblog commented Nov 15, 2024 •
edited
Loading

We should have a general code review. Some thoughts:

  • Add more inline comments
  • Remove duplicate code
  • Maybe improve abstractions
  • Normalize Code Style (phpcs)
  • Add type hints where possible
@martialblog
Copy link
Member Author

Code duplication:

private function getUserThemeMode(): string

This was referenced Nov 15, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@martialblog