Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty results aren't overwriting the default None #71

Open
maximusunc opened this issue Jul 10, 2024 · 0 comments
Open

Empty results aren't overwriting the default None #71

maximusunc opened this issue Jul 10, 2024 · 0 comments
Assignees

Comments

@maximusunc
Copy link
Collaborator

Here: https://github.com/NCATSTranslator/workflow-runner/blob/main/app/server.py#L184 a base message is created, which has results as None for default. Then below that we update it with the incoming message. If that message has an empty results list, reasoner-pydantic doesn't do anything and leaves it as None. This could either be fixed on reasoner-pydantic side, or we initialize that first base message with better defaults in this code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants