Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement] Reduce number of dependencies (bech32, bs58) #20739

Open
mahnunchik opened this issue Dec 26, 2024 · 2 comments
Open

[Improvement] Reduce number of dependencies (bech32, bs58) #20739

mahnunchik opened this issue Dec 26, 2024 · 2 comments
Assignees
Labels

Comments

@mahnunchik
Copy link

The number of dependencies can be reduced, making the package potentially more secure.

bech32 and bs58 can be removed in favor of @scure/base which is already in indirect dependencies list.

@mahnunchik
Copy link
Author

https://github.com/MystenLabs/sui/blob/main/sdk/bcs/src/hex.ts can be simplified as hex.decode and hex.encode from the same package @scure/base

@stefan-mysten
Copy link
Contributor

Thanks @mahnunchik! I'll flag it to the right folks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants