about libnfs api v2 change

[chenrui333]

👋 I saw there is libnfs v6 API compatibility change, but did not see it is part of the recent release, any reason why? Thanks!

relates to Homebrew/homebrew-core#200785

[heitbaum]

I tested an update to Kodi last night.

• libnfs: update to 6.0.x and api v2 LibreELEC/LibreELEC.tv#9568
• sahlberg/libnfs@5e8f7ce
• LibreELEC/LibreELEC.tv@5303bd9

and was looking at this this evening - as mpd is a LE addon.

[2/5] Compiling C++ object src/lib/nfs/libnfs.a.p/Connection.cxx.o
FAILED: src/lib/nfs/libnfs.a.p/Connection.cxx.o 
/var/media/DATA/home-rudi/LibreELEC.tv/build.LibreELEC-Generic.x86_64-13.0-devel/toolchain/bin/x86_64-libreelec-linux-gnu-g++ -Isrc/lib/nfs/libnfs.a.p -Isrc/lib/nfs -I../src/lib/nfs -Isrc -I../src -I. -I.. -I/var/media/DATA/home-rudi/LibreELEC.tv/build.LibreELEC-Generic.x86_64-13.0-devel/toolchain/x86_64-libreelec-linux-gnu/sysroot/usr/include -fdiagnostics-color=always -D_GLIBCXX_ASSERTIONS=1 -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wextra -Wpedantic -std=c++17 -ffast-math -ftree-vectorize -Wcast-qual -Wdouble-promotion -Wmissing-declarations -Wshadow -Wunused -Wvla -Wwrite-strings -Wno-stringop-overflow -fno-threadsafe-statics -fmerge-all-constants -Wcomma-subscript -Wextra-semi -Wmismatched-tags -Woverloaded-virtual -Wsign-promo -Wvolatile -Wvirtual-inheritance -Wno-non-virtual-dtor -Wsuggest-override -fvisibility=hidden -ffunction-sections -fdata-sections -D_GNU_SOURCE -march=x86-64-v3 -Wall -pipe -O2 -fomit-frame-pointer -DNDEBUG -fPIC -MD -MQ src/lib/nfs/libnfs.a.p/Connection.cxx.o -MF src/lib/nfs/libnfs.a.p/Connection.cxx.o.d -o src/lib/nfs/libnfs.a.p/Connection.cxx.o -c ../src/lib/nfs/Connection.cxx
../src/lib/nfs/Connection.cxx: In member function 'void NfsConnection::CancellableCallback::Read(nfs_context*, nfsfh*, uint64_t, size_t)':
../src/lib/nfs/Connection.cxx:110:47: error: invalid conversion from 'uint64_t' {aka 'long unsigned int'} to 'void*' [-fpermissive]
  110 |         int result = nfs_pread_async(ctx, fh, offset, size, Callback, this);
      |                                               ^~~~~~
      |                                               |
      |                                               uint64_t {aka long unsigned int}
../src/lib/nfs/Connection.cxx:110:37: error: cannot resolve overloaded function 'Callback' based on conversion to type 'uint64_t' {aka 'long unsigned int'}
  110 |         int result = nfs_pread_async(ctx, fh, offset, size, Callback, this);
      |                      ~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
ninja: build stopped: subcommand failed.

[heitbaum]

I did just check and the patch doesn’t apply cleanly to 0.23.16

[MaxKellermann]

A lot has changed in the NFS/storage code, and a backport will probably not happen. I hope I can finish 0.24 very soon so we don't waste more time on 0.23.

[christian-heusel]

This issue just came up again as we're now doing the libnfs6 rebuild in Arch Linux: https://archlinux.org/todo/libnfs6-support/

I tried backporting the changes but it turned out to be a major headache, so a (somewhat timely) 0.24 release would really be appreciated! 🤗

[MaxKellermann]

Sorry, I tried really hard to take my vacation in December to finish it, but other things crossed my plans. Yet again. Long ago, I had a plan to release MPD 1.0 for its 20th anniversary, but that date has passed 2 years ago already :-(

[christian-heusel]

Sometimes things don't got as planned, there is no shame in that 🤗
If the release takes a little longer than initially expected maybe commit a backported version to the 0.23.x branch is an option then? 😄