Bug Fix for Premium Beans Responsive UI - Fixed the Cards moving out of frame #297
+78
−19
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The UI of the Premium Beans change was fixed to ensure that for almost all device sizes, the cards do not move out of the frame or get cut out.
Pull Request Template
Summary
In the previous version, the UI of the Premium Beans page worked well for the full-screen view of a laptop, but under a mobile phone's screen size or under split screen, the cards for Arabica Bliss and Robusta Robusta Roast on the left and the Espresso Elite and Colombian Charm on the right moved out of the frame, and were only half-visible as the pictures attached to the issue. This issue was fixed by adjusting media parameters to cater to different screen sizes, and changed to a single column after a certain screen size so that cards do not move out of frame.
Fixes #293
Type of Change
Please mark [X] for applicable items:
Testing
Please describe the tests you performed to verify your changes:
(This is my first time making a pull request, please feel free point out to mistakes if there are any!)
Screenshots/Videos
Please attach relevant screenshots or videos demonstrating the changes.
1.1 PAGE BEFORE MAKING THE CHANGE (with cards overflowing to the sides)
PAGES AFTER MAKING CHANGES:
2. Page after further screen size reduction:
Page Under half-screen split screen size:
Page under average mobile phone screen size:
Checklist
Please mark [X] for completed items: