Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Background Image to Page #2

Open
MrAshwin2142 opened this issue Oct 30, 2023 · 22 comments
Open

Add Background Image to Page #2

MrAshwin2142 opened this issue Oct 30, 2023 · 22 comments
Labels

Comments

@MrAshwin2142
Copy link
Owner

Hello there! I've created this issue, and I'm excited to welcome new contributors to OpenQuotes. This is a great opportunity for beginners to start their open source journey.

Issue Details:

We're looking to enhance the visual appeal of the OpenQuotes project by adding a background image to the page. The image we have in mind is this beautiful Sakura flower background: Background Image.

Task:

Your task is to modify the project's CSS to incorporate this background image and make the page more aesthetically pleasing.

Getting Started:

Fork the OpenQuotes repository.
Clone your fork to your local machine.
Add the background image to the project's CSS.
Commit your changes and push to your fork.
Create a pull request to contribute your enhancement.

Acceptance Criteria:

The background image is visually appealing and responsive.
The image does not interfere with the readability of the quotes.
The project maintains its simplicity and readability.
Feel free to reach out if you have any questions or need guidance. This issue is marked as a "good first issue," making it an excellent starting point for your open source journey. We look forward to your contributions and to seeing the OpenQuotes project become even more inspiring and visually engaging.

Happy coding, and welcome to the OpenQuotes community! 🌸✨🚀

@MrAshwin2142
Copy link
Owner Author

🎉 Issue closed! Thanks, @Delta7Actual , for your fantastic contribution! Your work has made a big difference. We appreciate your dedication. Keep inspiring! 🚀🌟

@MrAshwin2142
Copy link
Owner Author

Hello everyone,

We've reopened the background change issue. The previous background image had low resolution, and we're in search of a high-quality replacement. If you have a stunning background image in mind, please share it in the comments. Your contribution is appreciated! 🌄

@MrAshwin2142 MrAshwin2142 reopened this Oct 31, 2023
@JohnPatrickAncajas
Copy link
Contributor

SAKURAFLOWER
Is this image good enough for the background? It's light and make the text readable and also looks good if cropped because of screen size.

@MrAshwin2142
Copy link
Owner Author

Thank you for your excellent suggestion regarding the background image. We believe it's a fantastic choice! 🌄
Could you please proceed with changing the background to this image and creating a pull request to implement the update?

@JohnPatrickAncajas
Copy link
Contributor

Will do! I'll follow that update after the previous one I'm working on so it would be separate in case of an error.

@pheb2014939ctu
Copy link
Contributor

Hello Sir,

I'm very interested in being a part of this project. I have some high-quality background images that I believe would be suitable. I'll send the images through a direct message. Thank you very much!

@MrAshwin2142
Copy link
Owner Author

hello @pheb2014939ctu thank you for showing interest in contributing, but @JohnPatrickAncajas already working on this, you can explore any other issue from the list or add any other issue to the enhancement

@pheb2014939ctu
Copy link
Contributor

It's OK. If there are any new issues that need attention, I'm more than willing to contribute to the project. Whether it's sourcing a new high-resolution background image or any other related matter, count me in to help find a solution. Your efforts in improving the project are greatly appreciated! 🌄

@JohnPatrickAncajas
Copy link
Contributor

Hello! I have tested the background and unfortunately, I do not think it would look good since the branches in this image blends with the text making it not so readable at that parts. You can help if you want to @pheb2014939ctu by sourcing images then I can try or I can pass this to you.

@JohnPatrickAncajas
Copy link
Contributor

Screenshot (126)
Here is a sample of the text over the branch which makes it hard to read. I can change the colors but I think black is still the best so another image is preferable.

@MrAshwin2142
Copy link
Owner Author

@pheb2014939ctu if you have any other better image, you can contribute or we can change text change to make it more readable

@JohnPatrickAncajas
Copy link
Contributor

JohnPatrickAncajas commented Oct 31, 2023

Screenshot (127)
Screenshot (128)
I found this one that looks good but it has some conflicts at mobile layout as you can see. Should I keep looking? or I can also do responsive backgrounds so its different for mobile instead

@pheb2014939ctu
Copy link
Contributor

@MrAshwin2142
Sure, if you make a full request for me , I'll add the image for your review.

@pheb2014939ctu
Copy link
Contributor

Screen Shot 2023-10-31 at 23 31 44 Screen Shot 2023-10-31 at 23 39 33 Screen Shot 2023-10-31 at 23 46 23

Which option would you prefer to select? Additionally, may I contribute more quotes to this website?

@JohnPatrickAncajas
Copy link
Contributor

You can add your quotes @pheb2014939ctu ! Specially if your helping this much

@MrAshwin2142
Copy link
Owner Author

@JohnPatrickAncajas just added a suitable background image, we can change the background image with every Quote.
@pheb2014939ctu you can contribute to that. if you want we can create an issue for this and assign it to you.

@JohnPatrickAncajas
Copy link
Contributor

I was just thinking of that, but changing it every hour! If you want help then I can join you @pheb2014939ctu, specially at the JavaScript.

@pheb2014939ctu
Copy link
Contributor

@MrAshwin2142
Could you kindly assign the task of adding a background image to me now, please?

@MrAshwin2142
Copy link
Owner Author

@pheb2014939ctu i have added new issue just comment on that i will assign you

@pheb2014939ctu
Copy link
Contributor

Dear @MrAshwin2142 , could you kindly open this issue and assign it to me? I'm eager to complete this task. I would greatly appreciate it if you could refrain from closing this. In my opinion, changing the images and quotes every 5 minutes might be too lengthy.

@MrAshwin2142 MrAshwin2142 reopened this Oct 31, 2023
@pheb2014939ctu
Copy link
Contributor

Screen Shot 2023-11-01 at 13 16 04 Screen Shot 2023-11-01 at 13 14 00 Screen Shot 2023-11-01 at 13 57 05

Considering the available background options, the approach of changing the background every 5 minutes results in a dynamic and regularly evolving environment, providing users with a consistently fresh experience.

@MrAshwin2142
Copy link
Owner Author

looks good ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants