Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow a maker to cancel an order in status waiting-buyer-invoice or waiting-payment #379

Open
Catrya opened this issue Oct 29, 2024 · 0 comments · May be fixed by #432
Open

Allow a maker to cancel an order in status waiting-buyer-invoice or waiting-payment #379

Catrya opened this issue Oct 29, 2024 · 0 comments · May be fixed by #432
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@Catrya
Copy link
Collaborator

Catrya commented Oct 29, 2024

If a user creates an order but wants to cancel it, if the order has already been taken by someone and is in status waiting-buyer-invoice or waiting-payment, the maker cannot cancel it and has to wait for the taker to cancel the order and go back to status pending to cancel it; but if the taker continues and does his part, then the maker cannot cancel it either, they has to wait for 15 min (or whatever time the mostro has set) to pass for the order to be cancelled because they has not done his part. IMHO this gives bad UX.

I think it would be good to allow the maker of an order to cancel it even if it is in status waiting-buyer-invoice or waiting-payment.

How it would work:
When a maker cancels the order it should go to status canceled.

Maker-Seller:

  • When the order is taken, it goes to the status waiting-buyer-invoice. If the seller cancels before the buyer submits the invoice, a message must be sent to the buyer that the order was cancelled, and a message must be sent to the maker with the Cancelled action.
  • If the buyer has already submitted the invoice, the order will go to the status waiting-payment. If the maker cancels it, the hold invoice must be cancelled, and cancellation messages must be sent to both the maker and the taker.

Maker-Buyer:

  • When the order is taken, it goes to the status waiting-payment. If the buyer cancels before the seller pays the hold invoice, the hold invoice must be cancelled and a message canceling the order must be sent to both.
  • If the order went to the status waiting-buyer-invoice bc the seller pays the hold invoice, if the buyer cancels, the hold invoice must be cancelled and a message canceling the order must be sent to both.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants