Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document use of additional modal classes in size property. #58

Open
alanmies opened this issue Oct 8, 2019 · 1 comment
Open

Document use of additional modal classes in size property. #58

alanmies opened this issue Oct 8, 2019 · 1 comment

Comments

@alanmies
Copy link

alanmies commented Oct 8, 2019

There are some Bootstrap 4 classes one might want to include in dialogs, such as "modal-dialog-centered" and "modal-dialog-scrollable" - short of rewriting the template code, those can be easily injected by including them in the "size" parameter for $uibModal.open. Like "size: 'md modal-dialog-centered'". So include this in the documentation as well?

@Morgul Morgul changed the title Slight update to documentation Document use of additional modal classes in size property. Oct 8, 2019
@Morgul
Copy link
Owner

Morgul commented Oct 8, 2019

@alanmies That's a great idea. While adding two more properties for this wouldn't be all that hard, this change makes for a pretty nice work around until/if that happens.

Morgul added a commit that referenced this issue Oct 16, 2019
Included suggestions from #58.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants