Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve code quality on the main branch #99

Open
3 tasks
CSchoel opened this issue Jul 15, 2021 · 1 comment
Open
3 tasks

Improve code quality on the main branch #99

CSchoel opened this issue Jul 15, 2021 · 1 comment
Assignees

Comments

@CSchoel
Copy link
Contributor

CSchoel commented Jul 15, 2021

  • After SonarQube and/or LGTM have been set up (Set up a tool that produces code quality metrics and reports code smells #98), fix all high severity issues that the tools report on the main branch
  • Also go through all lower severity issues and decide whether they need to be fixed
    • If possible, you can disable warnings for irrelevant issues, but you should be able to defend this decision with solid arguments.
  • Keep watch over all pull requests to the main branch, ensuring that no new high severity issues are introduced
@CptKaNe
Copy link
Contributor

CptKaNe commented Aug 5, 2021

Today I started improving the code quality. Therefore i created a new branch named codequality out of the main branch and had a look at the critical and major issues listed from sonarqube. However, I am insecure about the issues concerning the System.out.println() statements. Sonarqube wants us to replace these with a logger, but due to our consoleapplication this cannot be the right way i guess, so can we Ignore this issues?

In Addition to that @manuEbg & @IlmarB we should check that you are not working on code while I am about to refactor that so that we dont work against each other on these code fragments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants