Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sanitize user input #75

Open
CSchoel opened this issue Jun 28, 2021 · 0 comments
Open

Sanitize user input #75

CSchoel opened this issue Jun 28, 2021 · 0 comments
Labels
bug Something isn't working

Comments

@CSchoel
Copy link
Contributor

CSchoel commented Jun 28, 2021

Maybe you should think about sanitizing your user input. One example: Using the model name Modelica);exit(1 shuts down the OMC instance. 😉

There are all sorts of shenanigans that you can do with this, incuding executing arbitrary shell commands. This is not that big of an issue, since you can do this with Modelica code anyway, so it is safe to assume that Mo|E will only ever be used in a trusted or sandboxed context. However, you still might want to add at least an escape function so that you do not have to handle completely arbitrary responses by the OMC if the user inputs something crazy.

@CSchoel CSchoel added the bug Something isn't working label Jun 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant