Unit Menu Skills - How to add?

[JesterWizard]

Is the skill system at a stage where unit menu skills can be added? I tried recently and got stuck around UnitMenu.c trying to get my text strings to display.

[MokhaLeee]

same as decomp

[JesterWizard]

So I got most of the way there. The effect works, but the text doesn't display?

[JesterWizard]

Ignore me. I know why

[MokhaLeee]

According to the text you mentioned, I think it better to put them as a combat-art skills. Maybe you can pull the skill info first and wait for me to give you a sample how to achieve skill effects via combat-art.

Menu related operation means introduing a lot of new code and form a very deep call stack. This will create a lot of corner cases, since they will cooperate with the battle system, it will be more difficult to repair if something goes wrong. At the same time, we also need to consider how to easily introduce more skills on this basis. All this requires rigorous code reviews with caution.

[JesterWizard]

I got it working finally. I'm sure you already know most of what you want to do, but maybe you can use what I did as a basis as you form a more robust system? I ended up placing the skill unit menu names and descriptions in Texts.txt and the skill usability and effect definitions in skill-system.h. I also placed the effect and usability instances in MenuSkills.c.

What I have noticed is that the way UnitMenu.c is set up, the unit menu option name and descriptions require hardcoded addresses (take attack for example, attack, which uses 0x67B and 0x6C0). Will this not have an impact if certain skills are removed or moved around? I think the names should be used instead.

[MokhaLeee]

Two issue you need to ansower:

1. If the player close the game during battle-anim, how can their pre-selected skills continue to take effect after next time they reopen the game
2. If player canceled during target-selection and switch to control another character, how can you ensure that the skill can truely avoid to still take effect.

not to say you need to answer how to introduce more and more and more familiar skills.

[JesterWizard]

I haven't even gotten to that stage yet. Apparently I jumped the gun, as the skill doesn't take effect in battle. And to add a third point to your questions, I still need a way to make the skill take effect again after backing out of the battle forecast, returning to the weapon select screen and then navigating back to the battle forecast. I was setting a global flag for the skill in GambleCommandEffect here and then checking in the prebattle file for its value, but it doesn't persist in the above scenario.

[MokhaLeee]

#227