Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed plot from two examples, in order that runtests.jl works #54

Closed
MartinOtter opened this issue Sep 21, 2018 · 3 comments
Closed

Comments

@MartinOtter
Copy link
Member

Due to a bug in ModiaMath (see issue), ModiaMath.plot on arrays does not work. In order that runtests.jl works, temporarily deactivated ModiaMath.plot(...) calls that plot an array:

  • Modia/examples/LinearSystems.jl
  • Modia/test/models/TestSpatialDiscretization.jl
@HildingElmqvist
Copy link
Contributor

Strange. I was able to previously run all tests successfully.

@MartinOtter
Copy link
Member Author

The reason was the ModiaMath version 0.2.2 that I released yesterday. Here I included the feature that plots can be added to existing figures, without clearing the previous content. Hereby, I had to change the way how the legend of the plots is built.

I do not fully understand the reason, but my guess is that previously when an array was plotted in Modia (say vector x with 5 elements), then 5 lines are plotted and the legend was just "x" (so only of limited use). Due to the change in ModiaMath with the legend handling, this did no longer work (because the length of the legend vector is now assumed to have the same length as the number of array elements).

I know how to fix this in ModiaMath, but will not manage to do it today.

MartinOtter added a commit that referenced this issue Oct 6, 2018
@MartinOtter
Copy link
Member Author

Re-added the plot commands with commit 0ec2bd4
(works with ModiaMath 0.2.4).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants