Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong version tagged? #3

Open
enyo opened this issue May 23, 2016 · 1 comment
Open

Wrong version tagged? #3

enyo opened this issue May 23, 2016 · 1 comment

Comments

@enyo
Copy link

enyo commented May 23, 2016

When following the README:

# your commit with a "keyword"
git commit -am "feature: This is my new feature"
git tag 0.0.1 or git tag -am 0.0.1

# Write CHANGELOG.md and set the version in pubspec.yaml
changelog -x

# Push CHANGELOG.md and the changed (version) pubspec.yaml to origin
git commit -am "Released 0.0.1"
git push origin master

Doesn't this mean that the version in git that doesn't have the pubspec.yaml updated yet will be tagged as 0.0.1?
Isn't the correct approach this:

git commit -am "feature: This is my new feature"
# Now write changelog, set pubspec to 0.0.1 and create the git tag
# (This doesn't exist yet.)
changelog -x 0.0.1
git push origin master

That seems more logical to me

@jimsimon
Copy link

Yeah, there's two problems with the current implementation:

  1. The tagged commit doesn't include the CHANGELOG entries for that version
  2. The tagged commit's pubspec is behind by a release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants