Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Raise different exception type in decoding.py? #82

Open
StokesMIDE opened this issue Aug 4, 2021 · 0 comments
Open

Raise different exception type in decoding.py? #82

StokesMIDE opened this issue Aug 4, 2021 · 0 comments
Labels
Decoding Related to the importing of EBML data development Development issues: package deployment, project organization, etc. enhancement New feature or request

Comments

@StokesMIDE
Copy link
Member

StokesMIDE commented Aug 4, 2021 •
edited
Loading

IOError is raised several places in decoding.py; in hindsight, this is probably the wrong exception type, since it is an error in the data rather than an error accessing it. Some other exception type should be raised. While a ValueError would be more appropriate, maybe it should be a new subclass of IOError to maintain compatibility with existing code that uses ebmlite.

There is also one IOError raised in a similar situation in core.py that should probably be some other type.
@StokesMIDE StokesMIDE added enhancement New feature or request Decoding Related to the importing of EBML data development Development issues: package deployment, project organization, etc. labels Aug 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Decoding Related to the importing of EBML data development Development issues: package deployment, project organization, etc. enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@StokesMIDE