You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This is purely a selfish request - The ILoggerFactory is a common dotnet interface, which when using this library for anything will become the first-priority for selection. Downside is, it gets selected before the official MS libs if you are flying through code
Any chance those accessors could be marked internal instead of public? I am unsure why they would need to be exposed if they are in what most would say, an internal folder for lib internals only. Just my .02c, and again, purely selfish for my auto-complete sanity!
The idea was to expose that interface so that a consumer can write a forwarding wrapper which could send log messages to the Microsoft.Extensions.Logging framework for example.
For that it has to be public. I agree that the name could have been slightly different to prevent the issue you see, but hey..
An internal directory can totally have public APIs, its in internal to indicate it might change and the APIs might not be stable forever.
But to your request, I do not really want to change this atm. Sorry ;)
This is purely a selfish request - The
ILoggerFactory
is a common dotnet interface, which when using this library for anything will become the first-priority for selection. Downside is, it gets selected before the official MS libs if you are flying through codeAny chance those accessors could be marked
internal
instead of public? I am unsure why they would need to be exposed if they are in what most would say, aninternal
folder for lib internals only. Just my .02c, and again, purely selfish for my auto-complete sanity!DnsClient.NET/src/DnsClient/Internal/ILoggerFactory.cs
Line 5 in b9e9050
The text was updated successfully, but these errors were encountered: