Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wrong scripting in /usr/bin/emby-theater #147

Open
mk01 opened this issue Aug 31, 2024 · 1 comment
Open

wrong scripting in /usr/bin/emby-theater #147

mk01 opened this issue Aug 31, 2024 · 1 comment

Comments

@mk01
Copy link

mk01 commented Aug 31, 2024

guys,

wrapper to emby-theater (/usr/bin/emby-theater) is wrongly handling the params from /etc/emby-theater.conf.

    if [ ! $EMBY_SYSTEM_LIBVA_DRIVERS ]; then
        export LIBVA_DRIVERS_PATH=$APP_DIR/extra/lib/dri
    fi

[ ! xxx ] is evaluated as [ ! -n xxx ], that means that export will never be effective as long as the variable is existing and not empty. so use either

    if ! $EMBY_SYSTEM_LIBVA_DRIVERS; then

or

    if [ x$EMBY_SYSTEM_LIBVA_DRIVERS = xfalse ]; then

maybe not so visible in latest version (as the variable is true), but ver 3.0.19 had EMBY_SYSTEM_LIBVA_DRIVERS set to false, so regardless the system libs were used.

@LukePulverenti
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants