Go API Client: Invalid Go package name, contains hyphens

[Noah-Huppert]

The auto-generated Go API client has the package embyclient-rest-go in every source file. This is not a valid Go package name. An alternative valid package name would be embyclient_rest_go or embyclient if we want to follow best practices for package naming

[LukePulverenti]

@softworkz

[Noah-Huppert]

I found a few other issues with the Golang API. It seems like there were some duplicate struct names as well. Here is the openapi-generator config I used to successfully create a compilable version of the Golang API:

generatorName: go
inputSpec: # <your emby openapi.json>
outputDir: ./embyclient/
packageName: embyclient

# Required for Golang imports to work
gitHost: github.com
gitUserId: # <your git username>
gitRepoId: # <your git repo>

validateSpec: False
modelNamePrefix: Model

# Go generator
isGoSubmodule: True
withGoMod: False
structPrefix: True
enumClassPrefix: True

I then had to run this find and replace on the output files due to a bug where the openapi-generator seems to add the modelNamePrefix twice when referring to model structs:

sed -i 's/ModelModel/Model/g' embyclient/*.go

[softworkz]

I fixed the package name. Can you please check whether it's working now?

Publish.zip

[Noah-Huppert]

I fixed the package name. Can you please check whether it's working now?

Publish.zip

Sure thing. I'll give it a test when I have a moment free.

[LukePulverenti]

@Noah-Huppert ?

[Noah-Huppert]

Sorry still pending! I swear I'll get back to you!

…

@Noah-Huppert <https://github.com/Noah-Huppert> ? — Reply to this email directly, view it on GitHub <#3837 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAZLM4FOGWOWTYSPCHF3K7TZNPWH5AVCNFSM6AAAAABHTFVH36VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENBRG4ZDCNBTGM> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[LukePulverenti]

@Noah-Huppert ?

[Noah-Huppert]

@Noah-Huppert ?

Thanks for the new Publish.zip and apologies for my delay. Here is the output of go run when I import the Publish.zip contents as a directory named embyclient.

embyclient/model_color_formats.go:98:2: syntax error: unexpected literal 0, expected name
embyclient/model_color_formats.go:100:4: binary literal has no digits
embyclient/model_video_media_types.go:33:2: syntax error: unexpected literal 012, expected name

All the errors are bc you can't have variable that starts with a number in go

[LukePulverenti]

@softworkz

[softworkz]

I have adjusted the generation now.

@Noah-Huppert - can you check again please?

Publish.zip