From 186340798ce02a41888df758eee7c77404b45c06 Mon Sep 17 00:00:00 2001 From: Luke Pulverenti Date: Sun, 22 Apr 2018 15:38:50 -0400 Subject: [PATCH] update translations --- Emby.Dlna/Common/StateVariable.cs | 5 +- Emby.Dlna/ConfigurationExtension.cs | 2 +- .../ConnectionManagerXmlBuilder.cs | 4 +- .../ContentDirectoryXmlBuilder.cs | 2 +- Emby.Dlna/ContentDirectory/ControlHandler.cs | 16 +-- .../ServiceActionListBuilder.cs | 4 +- Emby.Dlna/Main/DlnaEntryPoint.cs | 2 +- .../ServiceActionListBuilder.cs | 4 +- Emby.Dlna/PlayTo/Device.cs | 2 +- Emby.Dlna/PlayTo/TransportCommands.cs | 2 +- Emby.Dlna/Service/ServiceXmlBuilder.cs | 2 +- Emby.Drawing/ImageProcessor.cs | 25 ++-- .../ApplicationHost.cs | 4 +- .../Channels/ChannelManager.cs | 2 +- .../Data/SqliteItemRepository.cs | 22 +-- .../Devices/DeviceManager.cs | 2 +- Emby.Server.Implementations/Dto/DtoService.cs | 6 +- .../Library/LibraryManager.cs | 2 +- .../Library/MediaSourceManager.cs | 2 +- .../Library/Resolvers/Movies/MovieResolver.cs | 3 +- .../LiveTv/EmbyTV/EmbyTV.cs | 61 +-------- .../LiveTv/EmbyTV/EncodedRecorder.cs | 4 +- .../LiveTv/LiveTvConfigurationFactory.cs | 2 +- .../LiveTv/LiveTvDtoService.cs | 23 ---- .../LiveTv/LiveTvManager.cs | 71 ++-------- .../LiveTv/LiveTvMediaSourceProvider.cs | 2 +- .../Localization/LocalizationManager.cs | 10 +- .../Networking/NetworkManager.cs | 15 +- .../NotificationConfigurationFactory.cs | 2 +- .../Playlists/PlaylistManager.cs | 16 ++- .../Services/ResponseHelper.cs | 12 -- .../TV/TVSeriesManager.cs | 16 ++- .../Updates/InstallationManager.cs | 1 - MediaBrowser.Api/Images/ImageService.cs | 8 +- MediaBrowser.Api/Library/LibraryService.cs | 36 +---- MediaBrowser.Api/LiveTv/LiveTvService.cs | 4 +- MediaBrowser.Api/Movies/MoviesService.cs | 2 +- MediaBrowser.Common/Net/INetworkManager.cs | 2 +- .../Progress/ActionableProgress.cs | 29 +--- .../Connect/ConnectSupporterSummary.cs | 19 --- .../Drawing/IImageProcessor.cs | 4 +- .../Drawing/ImageProcessingOptions.cs | 2 +- MediaBrowser.Controller/Dto/DtoOptions.cs | 3 +- MediaBrowser.Controller/Entities/Folder.cs | 118 ++++++++-------- .../Entities/InternalPeopleQuery.cs | 6 +- MediaBrowser.Controller/Entities/Share.cs | 2 +- MediaBrowser.Controller/Entities/Trailer.cs | 8 +- .../Entities/UserViewBuilder.cs | 10 +- .../Library/MetadataConfigurationStore.cs | 2 +- .../LiveTv/ILiveTvManager.cs | 4 +- .../LiveTv/ILiveTvService.cs | 7 - .../MediaBrowser.Controller.csproj | 1 - .../MediaEncoding/EncodingHelper.cs | 12 +- .../MediaEncoding/EncodingJobInfo.cs | 16 +-- .../Net/BasePeriodicWebSocketListener.cs | 6 +- .../Persistence/IItemRepository.cs | 14 -- MediaBrowser.Controller/Playlists/Playlist.cs | 6 +- .../Providers/ImageRefreshOptions.cs | 6 +- .../Providers/ItemLookupInfo.cs | 2 +- .../Providers/MetadataRefreshOptions.cs | 12 +- .../Sync/IServerSyncProvider.cs | 4 +- .../Sync/SyncedFileInfo.cs | 1 + .../TV/ITVSeriesManager.cs | 2 +- .../Parsers/BaseItemXmlParser.cs | 23 ++-- .../Parsers/PlaylistXmlParser.cs | 80 ----------- .../Dlna/ContentFeatureBuilder.cs | 8 +- .../Dlna/MediaFormatProfileResolver.cs | 12 +- MediaBrowser.Model/Dlna/StreamBuilder.cs | 4 +- MediaBrowser.Model/Dlna/StreamInfo.cs | 19 ++- MediaBrowser.Model/Dto/BaseItemDto.cs | 2 +- MediaBrowser.Model/Dto/MediaSourceInfo.cs | 4 +- MediaBrowser.Model/Entities/ItemReview.cs | 52 ------- MediaBrowser.Model/MediaBrowser.Model.csproj | 1 - MediaBrowser.Model/Services/IHttpResult.cs | 5 - .../Books/GoogleBooksProvider.cs | 45 ------ .../Manager/ItemImageProvider.cs | 2 +- .../Manager/MetadataService.cs | 10 +- .../MediaBrowser.Providers.csproj | 1 - .../Movies/MovieDbProvider.cs | 2 +- .../Movies/MovieMetadataService.cs | 2 +- .../TV/FanArt/FanartSeriesProvider.cs | 2 +- .../emby-webcomponents/itemhelper.js | 2 +- .../emby-webcomponents/strings/ar.json | 64 ++++----- .../emby-webcomponents/strings/be-by.json | 64 ++++----- .../emby-webcomponents/strings/bg-bg.json | 64 ++++----- .../emby-webcomponents/strings/ca.json | 64 ++++----- .../emby-webcomponents/strings/cs.json | 64 ++++----- .../emby-webcomponents/strings/da.json | 64 ++++----- .../emby-webcomponents/strings/de.json | 64 ++++----- .../emby-webcomponents/strings/el.json | 64 ++++----- .../emby-webcomponents/strings/en-gb.json | 64 ++++----- .../emby-webcomponents/strings/es-ar.json | 64 ++++----- .../emby-webcomponents/strings/es-mx.json | 64 ++++----- .../emby-webcomponents/strings/es.json | 64 ++++----- .../emby-webcomponents/strings/fi.json | 64 ++++----- .../emby-webcomponents/strings/fr-ca.json | 64 ++++----- .../emby-webcomponents/strings/fr.json | 64 ++++----- .../emby-webcomponents/strings/gsw.json | 64 ++++----- .../emby-webcomponents/strings/he.json | 64 ++++----- .../emby-webcomponents/strings/hr.json | 64 ++++----- .../emby-webcomponents/strings/hu.json | 64 ++++----- .../emby-webcomponents/strings/id.json | 64 ++++----- .../emby-webcomponents/strings/it.json | 64 ++++----- .../emby-webcomponents/strings/kk.json | 64 ++++----- .../emby-webcomponents/strings/ko.json | 64 ++++----- .../emby-webcomponents/strings/lt-lt.json | 64 ++++----- .../emby-webcomponents/strings/ms.json | 64 ++++----- .../emby-webcomponents/strings/nb.json | 64 ++++----- .../emby-webcomponents/strings/nl.json | 64 ++++----- .../emby-webcomponents/strings/pl.json | 66 ++++----- .../emby-webcomponents/strings/pt-br.json | 64 ++++----- .../emby-webcomponents/strings/pt-pt.json | 64 ++++----- .../emby-webcomponents/strings/ro.json | 64 ++++----- .../emby-webcomponents/strings/ru.json | 64 ++++----- .../emby-webcomponents/strings/sk.json | 64 ++++----- .../emby-webcomponents/strings/sl-si.json | 64 ++++----- .../emby-webcomponents/strings/sv.json | 64 ++++----- .../emby-webcomponents/strings/tr.json | 64 ++++----- .../emby-webcomponents/strings/uk.json | 64 ++++----- .../emby-webcomponents/strings/vi.json | 64 ++++----- .../emby-webcomponents/strings/zh-cn.json | 128 ++++++++---------- .../emby-webcomponents/strings/zh-hk.json | 64 ++++----- .../emby-webcomponents/strings/zh-tw.json | 64 ++++----- .../emby-webcomponents/sync/sync.js | 2 +- .../dashboard-ui/strings/fr.json | 10 +- .../dashboard-ui/strings/it.json | 56 ++++---- .../dashboard-ui/strings/pl.json | 8 +- .../dashboard-ui/strings/sk.json | 8 +- .../dashboard-ui/strings/zh-CN.json | 10 +- SharedVersion.cs | 2 +- ThirdParty/emby/Emby.Server.Connect.dll | Bin 62464 -> 62464 bytes ThirdParty/emby/Emby.Server.MediaEncoding.dll | Bin 275968 -> 274432 bytes ThirdParty/emby/Emby.Server.Sync.dll | Bin 176128 -> 175104 bytes 133 files changed, 1472 insertions(+), 2286 deletions(-) delete mode 100644 MediaBrowser.Controller/Connect/ConnectSupporterSummary.cs delete mode 100644 MediaBrowser.Model/Entities/ItemReview.cs delete mode 100644 MediaBrowser.Providers/Books/GoogleBooksProvider.cs diff --git a/Emby.Dlna/Common/StateVariable.cs b/Emby.Dlna/Common/StateVariable.cs index 7e0bc6ae8b..571e17d060 100644 --- a/Emby.Dlna/Common/StateVariable.cs +++ b/Emby.Dlna/Common/StateVariable.cs @@ -1,4 +1,5 @@ using System.Collections.Generic; +using System; namespace Emby.Dlna.Common { @@ -10,7 +11,7 @@ public class StateVariable public bool SendsEvents { get; set; } - public List AllowedValues { get; set; } + public string[] AllowedValues { get; set; } public override string ToString() { @@ -19,7 +20,7 @@ public override string ToString() public StateVariable() { - AllowedValues = new List(); + AllowedValues = Array.Empty(); } } } diff --git a/Emby.Dlna/ConfigurationExtension.cs b/Emby.Dlna/ConfigurationExtension.cs index b23bf0b112..f19f0dfb5d 100644 --- a/Emby.Dlna/ConfigurationExtension.cs +++ b/Emby.Dlna/ConfigurationExtension.cs @@ -16,7 +16,7 @@ public class DlnaConfigurationFactory : IConfigurationFactory { public IEnumerable GetConfigurations() { - return new List + return new ConfigurationStore[] { new ConfigurationStore { diff --git a/Emby.Dlna/ConnectionManager/ConnectionManagerXmlBuilder.cs b/Emby.Dlna/ConnectionManager/ConnectionManagerXmlBuilder.cs index 2a415c58e0..0666eda229 100644 --- a/Emby.Dlna/ConnectionManager/ConnectionManagerXmlBuilder.cs +++ b/Emby.Dlna/ConnectionManager/ConnectionManagerXmlBuilder.cs @@ -42,7 +42,7 @@ private IEnumerable GetStateVariables() DataType = "string", SendsEvents = false, - AllowedValues = new List + AllowedValues = new string[] { "OK", "ContentFormatMismatch", @@ -65,7 +65,7 @@ private IEnumerable GetStateVariables() DataType = "string", SendsEvents = false, - AllowedValues = new List + AllowedValues = new string[] { "Output", "Input" diff --git a/Emby.Dlna/ContentDirectory/ContentDirectoryXmlBuilder.cs b/Emby.Dlna/ContentDirectory/ContentDirectoryXmlBuilder.cs index 7a9bc18ad8..facc252146 100644 --- a/Emby.Dlna/ContentDirectory/ContentDirectoryXmlBuilder.cs +++ b/Emby.Dlna/ContentDirectory/ContentDirectoryXmlBuilder.cs @@ -99,7 +99,7 @@ private IEnumerable GetStateVariables() DataType = "string", SendsEvents = false, - AllowedValues = new List + AllowedValues = new string[] { "BrowseMetadata", "BrowseDirectChildren" diff --git a/Emby.Dlna/ContentDirectory/ControlHandler.cs b/Emby.Dlna/ContentDirectory/ControlHandler.cs index 6ae4fc7991..2017d2ecbc 100644 --- a/Emby.Dlna/ContentDirectory/ControlHandler.cs +++ b/Emby.Dlna/ContentDirectory/ControlHandler.cs @@ -311,7 +311,7 @@ private IEnumerable> HandleBrowse(IDictionary> + return new [] { new KeyValuePair("Result", resXML), new KeyValuePair("NumberReturned", provided.ToString(_usCulture)), @@ -1135,7 +1135,7 @@ private QueryResult GetMusicLatest(BaseItem parent, User user, Inter ParentId = parent == null ? null : parent.Id.ToString("N"), GroupItems = true - }, query.DtoOptions).Select(i => i.Item1 ?? i.Item2.FirstOrDefault()).Where(i => i != null).ToList(); + }, query.DtoOptions).Select(i => i.Item1 ?? i.Item2.FirstOrDefault()).Where(i => i != null).ToArray(); return ToResult(items); } @@ -1150,7 +1150,7 @@ private QueryResult GetNextUp(BaseItem parent, User user, InternalIt StartIndex = query.StartIndex, UserId = query.User.Id.ToString("N") - }, new List { parent }, query.DtoOptions); + }, new [] { parent }, query.DtoOptions); return ToResult(result); } @@ -1167,7 +1167,7 @@ private QueryResult GetTvLatest(BaseItem parent, User user, Internal ParentId = parent == null ? null : parent.Id.ToString("N"), GroupItems = false - }, query.DtoOptions).Select(i => i.Item1 ?? i.Item2.FirstOrDefault()).Where(i => i != null).ToList(); + }, query.DtoOptions).Select(i => i.Item1 ?? i.Item2.FirstOrDefault()).Where(i => i != null).ToArray(); return ToResult(items); } @@ -1184,7 +1184,7 @@ private QueryResult GetMovieLatest(BaseItem parent, User user, Inter ParentId = parent == null ? null : parent.Id.ToString("N"), GroupItems = true - }, query.DtoOptions).Select(i => i.Item1 ?? i.Item2.FirstOrDefault()).Where(i => i != null).ToList(); + }, query.DtoOptions).Select(i => i.Item1 ?? i.Item2.FirstOrDefault()).Where(i => i != null).ToArray(); return ToResult(items); } @@ -1249,15 +1249,15 @@ private QueryResult GetMusicGenreItems(BaseItem item, Guid? parentId return ToResult(result); } - private QueryResult ToResult(List result) + private QueryResult ToResult(BaseItem[] result) { var serverItems = result .Select(i => new ServerItem(i)) - .ToArray(result.Count); + .ToArray(result.Length); return new QueryResult { - TotalRecordCount = result.Count, + TotalRecordCount = result.Length, Items = serverItems }; } diff --git a/Emby.Dlna/ContentDirectory/ServiceActionListBuilder.cs b/Emby.Dlna/ContentDirectory/ServiceActionListBuilder.cs index 8e3821e7c8..8e5c07ce2f 100644 --- a/Emby.Dlna/ContentDirectory/ServiceActionListBuilder.cs +++ b/Emby.Dlna/ContentDirectory/ServiceActionListBuilder.cs @@ -7,7 +7,7 @@ public class ServiceActionListBuilder { public IEnumerable GetActions() { - var list = new List + return new [] { GetSearchCapabilitiesAction(), GetSortCapabilitiesAction(), @@ -18,8 +18,6 @@ public IEnumerable GetActions() GetXSetBookmarkAction(), GetBrowseByLetterAction() }; - - return list; } private ServiceAction GetGetSystemUpdateIDAction() diff --git a/Emby.Dlna/Main/DlnaEntryPoint.cs b/Emby.Dlna/Main/DlnaEntryPoint.cs index a68e8697dd..35259a8a49 100644 --- a/Emby.Dlna/Main/DlnaEntryPoint.cs +++ b/Emby.Dlna/Main/DlnaEntryPoint.cs @@ -248,7 +248,7 @@ private async Task RegisterServerEndpoints() SetProperies(device, fullService); _Publisher.AddDevice(device); - var embeddedDevices = new List + var embeddedDevices = new [] { "urn:schemas-upnp-org:service:ContentDirectory:1", "urn:schemas-upnp-org:service:ConnectionManager:1", diff --git a/Emby.Dlna/MediaReceiverRegistrar/ServiceActionListBuilder.cs b/Emby.Dlna/MediaReceiverRegistrar/ServiceActionListBuilder.cs index 691ba3061a..bce8bfaef3 100644 --- a/Emby.Dlna/MediaReceiverRegistrar/ServiceActionListBuilder.cs +++ b/Emby.Dlna/MediaReceiverRegistrar/ServiceActionListBuilder.cs @@ -7,7 +7,7 @@ public class ServiceActionListBuilder { public IEnumerable GetActions() { - var list = new List + return new [] { GetIsValidated(), GetIsAuthorized(), @@ -17,8 +17,6 @@ public IEnumerable GetActions() GetGetValidationRevokedUpdateID(), GetGetValidationSucceededUpdateID() }; - - return list; } private ServiceAction GetIsValidated() diff --git a/Emby.Dlna/PlayTo/Device.cs b/Emby.Dlna/PlayTo/Device.cs index cd828e090a..c30acda5cc 100644 --- a/Emby.Dlna/PlayTo/Device.cs +++ b/Emby.Dlna/PlayTo/Device.cs @@ -368,7 +368,7 @@ private Task SetPlay(TransportCommands avCommands, CancellationToken cancellatio { var command = avCommands.ServiceActions.FirstOrDefault(c => c.Name == "Play"); if (command == null) - return Task.FromResult(true); + return Task.CompletedTask; var service = GetAvTransportService(); diff --git a/Emby.Dlna/PlayTo/TransportCommands.cs b/Emby.Dlna/PlayTo/TransportCommands.cs index 4f8926175a..9e055f7921 100644 --- a/Emby.Dlna/PlayTo/TransportCommands.cs +++ b/Emby.Dlna/PlayTo/TransportCommands.cs @@ -108,7 +108,7 @@ private static StateVariable FromXml(XElement container) { Name = container.GetValue(uPnpNamespaces.svc + "name"), DataType = container.GetValue(uPnpNamespaces.svc + "dataType"), - AllowedValues = allowedValues + AllowedValues = allowedValues.ToArray() }; } diff --git a/Emby.Dlna/Service/ServiceXmlBuilder.cs b/Emby.Dlna/Service/ServiceXmlBuilder.cs index 08eb804033..c41f1b3bed 100644 --- a/Emby.Dlna/Service/ServiceXmlBuilder.cs +++ b/Emby.Dlna/Service/ServiceXmlBuilder.cs @@ -72,7 +72,7 @@ private void AppendServiceStateTable(StringBuilder builder, IEnumerable" + DescriptionXmlBuilder.Escape(item.Name ?? string.Empty) + ""); builder.Append("" + DescriptionXmlBuilder.Escape(item.DataType ?? string.Empty) + ""); - if (item.AllowedValues.Count > 0) + if (item.AllowedValues.Length > 0) { builder.Append(""); foreach (var allowedValue in item.AllowedValues) diff --git a/Emby.Drawing/ImageProcessor.cs b/Emby.Drawing/ImageProcessor.cs index a5f55c91cc..b01166324b 100644 --- a/Emby.Drawing/ImageProcessor.cs +++ b/Emby.Drawing/ImageProcessor.cs @@ -208,7 +208,7 @@ public async Task> ProcessImage(ImageProcessingO dateModified = supportedImageInfo.Item2; var requiresTransparency = TransparentImageTypes.Contains(Path.GetExtension(originalImagePath) ?? string.Empty); - if (options.Enhancers.Count > 0) + if (options.Enhancers.Length > 0) { if (item == null) { @@ -541,7 +541,7 @@ public string GetImageCacheTag(BaseItem item, ItemImageInfo image) /// The image enhancers. /// Guid. /// item - public string GetImageCacheTag(BaseItem item, ItemImageInfo image, List imageEnhancers) + public string GetImageCacheTag(BaseItem item, ItemImageInfo image, IImageEnhancer[] imageEnhancers) { if (item == null) { @@ -563,7 +563,7 @@ public string GetImageCacheTag(BaseItem item, ItemImageInfo image, List> GetEnhancedImage(ItemImageInfo bool inputImageSupportsTransparency, BaseItem item, int imageIndex, - List enhancers, + IImageEnhancer[] enhancers, CancellationToken cancellationToken) { var originalImagePath = image.Path; @@ -693,7 +693,7 @@ private async Task> GetEnhancedImageInternal(string original BaseItem item, ImageType imageType, int imageIndex, - List supportedEnhancers, + IImageEnhancer[] supportedEnhancers, string cacheGuid, CancellationToken cancellationToken) { @@ -717,8 +717,8 @@ private async Task> GetEnhancedImageInternal(string original } // All enhanced images are saved as png to allow transparency - var cacheExtension = _imageEncoder.SupportedOutputFormats.Contains(ImageFormat.Webp) ? - ".webp" : + var cacheExtension = _imageEncoder.SupportedOutputFormats.Contains(ImageFormat.Webp) ? + ".webp" : (treatmentRequiresTransparency ? ".png" : ".jpg"); var enhancedImagePath = GetCachePath(EnhancedImageCachePath, cacheGuid + cacheExtension); @@ -842,9 +842,9 @@ public void CreateImageCollage(ImageCollageOptions options) _logger.Info("Completed creation of image collage and saved to {0}", options.OutputPath); } - public List GetSupportedEnhancers(BaseItem item, ImageType imageType) + public IImageEnhancer[] GetSupportedEnhancers(BaseItem item, ImageType imageType) { - var list = new List(); + List list = null; foreach (var i in ImageEnhancers) { @@ -852,6 +852,10 @@ public List GetSupportedEnhancers(BaseItem item, ImageType image { if (i.Supports(item, imageType)) { + if (list == null) + { + list = new List(); + } list.Add(i); } } @@ -860,7 +864,8 @@ public List GetSupportedEnhancers(BaseItem item, ImageType image _logger.ErrorException("Error in image enhancer: {0}", ex, i.GetType().Name); } } - return list; + + return list == null ? new IImageEnhancer[] { } : list.ToArray(); } private Dictionary _locks = new Dictionary(); diff --git a/Emby.Server.Implementations/ApplicationHost.cs b/Emby.Server.Implementations/ApplicationHost.cs index 2de10d18c3..798bbb53f5 100644 --- a/Emby.Server.Implementations/ApplicationHost.cs +++ b/Emby.Server.Implementations/ApplicationHost.cs @@ -1552,9 +1552,7 @@ protected List> GetTypes(Tuple assemblyInf private IEnumerable GetUrlPrefixes() { - var hosts = new List(); - - hosts.Add("+"); + var hosts = new[] { "+" }; return hosts.SelectMany(i => { diff --git a/Emby.Server.Implementations/Channels/ChannelManager.cs b/Emby.Server.Implementations/Channels/ChannelManager.cs index 046d495588..8bb0dae3b9 100644 --- a/Emby.Server.Implementations/Channels/ChannelManager.cs +++ b/Emby.Server.Implementations/Channels/ChannelManager.cs @@ -1065,7 +1065,7 @@ private BaseItem GetChannelItemEntity(ChannelItemInfo info, IChannel channelProv _logger.Debug("Forcing update due to TrailerTypes {0}", item.Name); forceUpdate = true; } - trailer.TrailerTypes = info.TrailerTypes; + trailer.TrailerTypes = info.TrailerTypes.ToArray(); } if (info.DateModified > item.DateModified) diff --git a/Emby.Server.Implementations/Data/SqliteItemRepository.cs b/Emby.Server.Implementations/Data/SqliteItemRepository.cs index 1b96abfbe6..7073ba3dae 100644 --- a/Emby.Server.Implementations/Data/SqliteItemRepository.cs +++ b/Emby.Server.Implementations/Data/SqliteItemRepository.cs @@ -920,7 +920,7 @@ private void SaveItem(BaseItem item, BaseItem topParent, string userDataKey, ISt } var trailer = item as Trailer; - if (trailer != null && trailer.TrailerTypes.Count > 0) + if (trailer != null && trailer.TrailerTypes.Length > 0) { saveItemStatement.TryBind("@TrailerTypes", string.Join("|", trailer.TrailerTypes.Select(i => i.ToString()).ToArray())); } @@ -1748,7 +1748,7 @@ private BaseItem GetItem(IReadOnlyList reader, InternalItemsQue } return (TrailerType?)null; - }).Where(i => i.HasValue).Select(i => i.Value).ToList(); + }).Where(i => i.HasValue).Select(i => i.Value).ToArray(); } } index++; @@ -2017,24 +2017,6 @@ private Guid[] SplitToGuids(string value) return result; } - /// - /// Gets the critic reviews. - /// - /// The item id. - public List GetCriticReviews(Guid itemId) - { - return new List(); - } - - /// - /// Saves the critic reviews. - /// - /// The item id. - /// The critic reviews. - public void SaveCriticReviews(Guid itemId, IEnumerable criticReviews) - { - } - /// /// Gets chapters for an item /// diff --git a/Emby.Server.Implementations/Devices/DeviceManager.cs b/Emby.Server.Implementations/Devices/DeviceManager.cs index 7a15e687c9..77a3954ec4 100644 --- a/Emby.Server.Implementations/Devices/DeviceManager.cs +++ b/Emby.Server.Implementations/Devices/DeviceManager.cs @@ -437,7 +437,7 @@ public class DevicesConfigStore : IConfigurationFactory { public IEnumerable GetConfigurations() { - return new List + return new ConfigurationStore[] { new ConfigurationStore { diff --git a/Emby.Server.Implementations/Dto/DtoService.cs b/Emby.Server.Implementations/Dto/DtoService.cs index a4c10696df..e460b152af 100644 --- a/Emby.Server.Implementations/Dto/DtoService.cs +++ b/Emby.Server.Implementations/Dto/DtoService.cs @@ -267,7 +267,7 @@ private BaseItemDto GetBaseItemDtoInternal(BaseItem item, DtoOptions options, Li { if (fields.Contains(ItemFields.MediaSources)) { - dto.MediaSources = _mediaSourceManager().GetStaticMediaSources(item, true, user); + dto.MediaSources = _mediaSourceManager().GetStaticMediaSources(item, true, user).ToArray(); NormalizeMediaSourceContainers(dto); } @@ -1190,7 +1190,7 @@ private void AttachBasicFields(BaseItemDto dto, BaseItem item, BaseItem owner, D { MediaStream[] mediaStreams; - if (dto.MediaSources != null && dto.MediaSources.Count > 0) + if (dto.MediaSources != null && dto.MediaSources.Length > 0) { if (item.SourceType == SourceType.Channel) { @@ -1515,7 +1515,7 @@ public void AttachPrimaryImageAspectRatio(IItemDto dto, BaseItem item) if (defaultAspectRatio.HasValue) { - if (supportedEnhancers.Count == 0) + if (supportedEnhancers.Length == 0) { return defaultAspectRatio.Value; } diff --git a/Emby.Server.Implementations/Library/LibraryManager.cs b/Emby.Server.Implementations/Library/LibraryManager.cs index 23a1476811..2a7a4a4605 100644 --- a/Emby.Server.Implementations/Library/LibraryManager.cs +++ b/Emby.Server.Implementations/Library/LibraryManager.cs @@ -2596,7 +2596,7 @@ public IEnumerable