Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Negative coverage: unsupported cipher suites #9765

Open
gilles-peskine-arm opened this issue Nov 7, 2024 · 0 comments
Open

Negative coverage: unsupported cipher suites #9765

gilles-peskine-arm opened this issue Nov 7, 2024 · 0 comments
Labels
enhancement size-m Estimated task size: medium (~1w)

Comments

@gilles-peskine-arm
Copy link
Contributor

We mostly don't test what happens if a peer tries to negotiate a cipher suite that isn't supported, either because Mbed TLS doesn't implement it or because it's disabled at compile time.

The goal of this issue is to add systematic testing that covers at least all the cipher suites that Mbed TLS can support, and one more. Run an OpenSSL/GnuTLS client/server with a forced cipher suite against an Mbed TLS peer that doesn't support that cipher suite, and check that the handshake fails gracefully.

We already have code to enumerate cipher suites and attempt a key exchange in compat.sh, so that seems the natural place for such tests. Instead of arranging not to try unsupported cipher suites, we should try everything that GnuTLS and OpenSSL support, but expect a handshake failure if Mbed TLS doesn't support the cipher suite.

@gilles-peskine-arm gilles-peskine-arm added enhancement size-m Estimated task size: medium (~1w) labels Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement size-m Estimated task size: medium (~1w)
Projects
Status: No status
Development

No branches or pull requests

1 participant