Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parsing incorrectly #100

Open
copenhaus opened this issue Nov 25, 2020 · 4 comments
Open

parsing incorrectly #100

copenhaus opened this issue Nov 25, 2020 · 4 comments

Comments

@copenhaus
Copy link

Hi, I'd like to report that whenever the Issuer has the character, comma, in its name, the output failed to parse the Issuer correctly.

As a sample: https://imgur.com/a/aq5kufb

Thanks...

@woraccmsq
Copy link

Yeah, I'm also faced with this, for example:
ssl-cert-check -s acme.com/page -p 443

Host Status Expires Days


ERROR: The file named /var/tmp/cert.X0uptO is unreadable or doesn't exist
ERROR: Please check to make sure the certificate for acme.com/page:443 is valid

@woraccmsq
Copy link

After update to 4.14:
ssl-cert-check -s acme.com/page -p 443

Host Status Expires Days


acme.com/page:443 Unable to resolve the DNS name acme.com/page Unknown 0, 0 0

@sandykadam
Copy link

sandykadam commented Apr 19, 2021

ERROR: The file named /var/tmp/cert.kK1m3s is unreadable or doesn't exist,ERROR: Please check to make sure the certificate for somedomain-name.net:443 is valid

Instead of showing this error, can we return user friendly msg e.g UNKNOWN or NA or INVALID CERTS

Because of this error, my whole dashboard is breaking

@lewart3
Copy link

lewart3 commented Jan 19, 2022

All,

1) Attached is a patch which fixes the original "Certificate Issuer with a comma" bug

2a) acme.com/page is an invalid hostname; use acme.com
2b) -p 443 is unnecessary, since that is the default

Enjoy!
Daniel Lewart
Urbana, Illinois

[certissuer.txt](https://github.com/Matty9191/ssl-cert-check/files/7896453/certissuer.txt

#115

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants