Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In 3.0.3 and later onAfterPrint is called only after clicking back on the page #779

Open
sergey-hippo opened this issue Jan 3, 2025 · 4 comments · May be fixed by #780
Open

In 3.0.3 and later onAfterPrint is called only after clicking back on the page #779

sergey-hippo opened this issue Jan 3, 2025 · 4 comments · May be fixed by #780

Comments

@sergey-hippo
Copy link

When using version 3.0.3 or 3.0.4, onAfterPrint is called only after clicking back on the page after print dialogue is closed.
This behavior is not present in 3.0.2

@MatthewHerbst
Copy link
Owner

Ah, I was afraid something like this might happen. This is likely caused by #764. Could you please let me know what browser you are using? The browsers I tested restored focus to the page automatically after closing the dialog, but I was afraid some might not.

@sergey-hippo
Copy link
Author

I'm using Vivaldi 6.8.3381.48 on macOS Version 15.2 and the issue is 100% reproducible for me.

@MatthewHerbst
Copy link
Owner

I will try to get a fix out this evening. I'll either find a way to combine the original solution with #764, or I'll revert #764

@sensasi-delight
Copy link
Contributor

Hi, I just wanted to confirm that I can reproduce this issue on Vivaldi v6 and v7, as well as Chrome and Edge v131 on my Windows 11 setup. I'll be submitting a PR shortly to address this issue while ensuring compatibility with the solution for issue #187.

@sensasi-delight sensasi-delight linked a pull request Jan 7, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants