Adding benchmarks for git domain #719
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tegefaulkes
changed the base branch from
staging
to
feature-eng-68-review-and-refactor-of-gitutilsts-for-serving-vault-git
tegefaulkes
force-pushed
the
feature-git-benchmarks
branch
from
a5454ee
to
7dd322b
Compare
[ci skip]
[ci skip]
tegefaulkes
force-pushed
the
feature-git-benchmarks
branch
from
7dd322b
to
2a2013e
Compare
tegefaulkes
changed the base branch from
feature-eng-68-review-and-refactor-of-gitutilsts-for-serving-vault-git
to
staging
|
Switched base over staging now that git refactoring has been merged. |
|
I feel like the suites need to be named better. |
|
I think we can merge what we have so far and revisit the issue again later. This will need a quick review and I can work on merging it soon. |
|
The benchmarks right now look quite messy. |
|
But before further benchmarking, the infrastructure should be upgraded with a bot so we can compare statistics and monitor for performance regressions @brynblack. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds benchmarks for the git domain. Mostly to have a good point of reference when making optimisation upgrades to the
DBandEFS.NOTE: this is targeting another feature branch while it is worked on. This is blocked by the git refactoring and requires that to be merged before switching the target branch to staging and merging.
Issues Fixed
gitdomain topolykey#717Tasks
Final checklist