Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding benchmarks for git domain to polykey #717

Open
tegefaulkes opened this issue May 13, 2024 · 3 comments · May be fixed by #719
Open

Adding benchmarks for git domain to polykey #717

tegefaulkes opened this issue May 13, 2024 · 3 comments · May be fixed by #719
Labels
development Standard development r&d:polykey:core activity 1 Secret Vault Sharing and Secret History Management

Comments

@tegefaulkes
Copy link
Contributor

Specification

After refactoring the git domain in #709 and simpifying the git code significantly. I noticed that the performance when cloning wasn't that much improved. This was purely a vibes based observation so we need to add benchmarks to for the git domain to determine performance changes later down the line. This is very important so we can compare improvements when updating the efs and js-db repos to be more performant.

Benchmarks will be added for each git/http.ts and git/utils.ts function to get an idea of which parts do the most processing. We will also add a full integration benchmark for doing an clone and pull example using isomorphic-git.

Each benchmark will compare the following where apropriate.

  1. Running using fs.
  2. Running using efs.
  3. Running over the RPC.
  4. Running over RPC AND efs.

We may not need to cover every function or example but being able to compare baseline fs with efs and rpc examples would be good for determining where the slowdowns are. I'm already pretty sure it's the db and efs being the core source of the slowdown.

Additional context

Tasks

  1. Create benchmarks for each relevant git domain function and generator.
  2. Ensure we test each case of using the fs, efs rpc and the combo of efs+rpc.
@tegefaulkes tegefaulkes added the development Standard development label May 13, 2024
@tegefaulkes tegefaulkes self-assigned this May 13, 2024
Copy link

linear bot commented May 13, 2024

@CMCDragonkai
Copy link
Member

I remember seeing you did some benching recently on the development discord channel.

@tegefaulkes
Copy link
Contributor Author

That was a part of working on this. I've shifted to focusing on other things for now since this is relatively lower priority.

@tegefaulkes tegefaulkes removed their assignment Jul 31, 2024
@CMCDragonkai CMCDragonkai added the r&d:polykey:core activity 1 Secret Vault Sharing and Secret History Management label Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
development Standard development r&d:polykey:core activity 1 Secret Vault Sharing and Secret History Management
Development

Successfully merging a pull request may close this issue.

2 participants