Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better UI for copy button #2581

Open
yucheng11122017 opened this issue Dec 21, 2024 · 2 comments
Open

Better UI for copy button #2581

yucheng11122017 opened this issue Dec 21, 2024 · 2 comments

Comments

@yucheng11122017
Copy link
Contributor

Please confirm that you have searched existing issues in the repo

Yes, I have searched the existing issues

Any related issues?

#2580

What is the area that this feature belongs to?

No response

Is your feature request related to a problem? Please describe.

Few points brought up

  • Pop up that code has been copied. While @Incogdino's new feature has made it clearer, a notification saying copied is quite common
  • Enable users to disable this if they want

Describe the solution you'd like

Add pop up
Enable users to add one line to the copy plugin to disable the tick icon

Describe alternatives you've considered

No response

Additional context

No response

@damithc
Copy link
Contributor

damithc commented Dec 21, 2024

  • Pop up that code has been copied. While @Incogdino's new feature has made it clearer, a notification saying copied is quite common

Preferably, something subtle and doesn't require any action from (or gets in the way of) the user?

  • Enable users to disable this if they want

This one is useful but best to analyse cost vs benefit to see if it is worth implementing.

@Incogdino
Copy link
Contributor

I think a popover would better suit the needs of this enhancement instead of a popup since a popup might require users to explicitly close it.

Also, I was thinking if it would be good to have a popover that appears when hovered indicating the action of the button. This is because although the copy button might be intuitive, the text wrap button might not be very intuitive to readers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants