Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw error when the build is successful but in fact broken due to errors #14

Open
tlylt opened this issue Oct 1, 2023 · 0 comments
Open

Comments

@tlylt
Copy link
Collaborator

tlylt commented Oct 1, 2023

Sometimes build succeeds even though there is a build error:
image

The overall action status is Green, so users might not even realize there's a problem
image

We should somehow give a warning, or fail the action job entirely when we detect errors in the console output of markbind build.

Reference: https://github.com/AY2324S1-CS2103T-W08-1/tp/actions/runs/6364130962/job/17280202044

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant