Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] .gcmon Config File #35

Open
workgroupengineering opened this issue Dec 3, 2021 · 5 comments · May be fixed by #36
Open

[Feature] .gcmon Config File #35

workgroupengineering opened this issue Dec 3, 2021 · 5 comments · May be fixed by #36

Comments

@workgroupengineering
Copy link

Allow dotnet-gcmon to recursively crawling the configuration file like .editorconfig

@MokoSan
Copy link
Contributor

MokoSan commented Dec 4, 2021

@workgroupengineering, could you please clarify what you mean by "recursively crawling configuration"?
From my understanding, .editorconfig allows to override behavior based on the folder you are in. I am missing how adding different config files to different directories will help override the logic. Unless you meant: if changes are dynamically added, the process should automatically pick it up using an abstraction like the FileWatcher?

@workgroupengineering
Copy link
Author

dotnet-gcmon first checks the current directory if .gcmon exists, if not found it recursively searches the parent folder until it is found or arrived to the root of the volume. If no .gcmon was found, default configuration is used.

@workgroupengineering workgroupengineering linked a pull request Dec 4, 2021 that will close this issue
@Maoni0
Copy link
Owner

Maoni0 commented Dec 12, 2021

can you please explain what would be the value of providing this? we already have the option to allow the user to specify a config of their choice.

@workgroupengineering
Copy link
Author

  • less verbose command line arguments
  • multilevel configuration example:
    solution            
      └.gcmon
      └Prj1
           └.gcmon
           └Prj1.csproj
           └....
      └Prj2
           └Prj2.csproj
           └...
    
    in the example above if you run dotnet-gcmon in the Prj1 folder, dotnet-gcmon using config preset in the current directory, otherwise dotnet-gcmon will use the configuration present at the solution level.

@Maoni0
Copy link
Owner

Maoni0 commented Dec 14, 2021

we already have a default config file so you don't need to specify a config on the commandline unless you want to change it. most users would use that config file. the scenario you illustrated is only for folks who actually do development on the tool which is a very small percentage. so introducing yet another config doesn't seem warranted. it's another config for the tool to maintain/care about.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants