Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cargo Clippy CI Optimizations #308

Open
SupremoUGH opened this issue Jan 17, 2023 · 0 comments
Open

Cargo Clippy CI Optimizations #308

SupremoUGH opened this issue Jan 17, 2023 · 0 comments
Labels
A-ci Area: Continuous Integration

Comments

@SupremoUGH
Copy link
Contributor

In our CI, we run
cargo hack clippy --workspace --feature-powerset --depth 3
and then
cargo hack clippy --workspace --feature-powerset --depth 3 --bins.
However,
cargo hack clippy --workspace --feature-powerset --depth 3 checks both the libraries and the binaries. I propose changing the CI to
cargo hack clippy --workspace --feature-powerset --depth 3 --lib
and
cargo hack clippy --workspace --feature-powerset --depth 3 --bins.

Also, we run
cargo hack clippy --workspace --feature-powerset --depth 3 --examples
which is a no-op because we don't have any. Why don't we remove it until it makes sense?

@bhgomes bhgomes changed the title CI Cargo Clippy CI Optimizations Jan 17, 2023
@bhgomes bhgomes added the A-ci Area: Continuous Integration label Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-ci Area: Continuous Integration
Projects
None yet
Development

No branches or pull requests

2 participants