You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The focus of this story is to extract logic from LoadedComicInfo class.
With all the cover attributes, the class has become polluted.
Some possible ideas:
Move logic outside using command design pattern (Would require a complete rework)
Divide the class into subclases processing, metadata and cover. (procesign implements metadata and cover processing/functionality due to it being the one that actually saves to files)
While at it it'd be required to add more unit tests since it's the core of MangaManager.
To sum up, a todo list:
Design a new structure that's clearer and easier to read
Easy accesible for plugins
Unit tests
Small PRs at a time
The text was updated successfully, but these errors were encountered:
The focus of this story is to extract logic from LoadedComicInfo class.
With all the cover attributes, the class has become polluted.
Some possible ideas:
While at it it'd be required to add more unit tests since it's the core of MangaManager.
To sum up, a todo list:
The text was updated successfully, but these errors were encountered: