Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix segfault in tests by waiting on map #121

Merged
merged 5 commits into from
Dec 30, 2024
Merged

Fix segfault in tests by waiting on map #121

merged 5 commits into from
Dec 30, 2024

Conversation

asinghvi17
Copy link
Member

No description provided.

@SimonDanisch
Copy link
Member

Could have been the nthreads > 1

@lazarusA lazarusA mentioned this pull request Dec 30, 2024
@asinghvi17
Copy link
Member Author

Ah, so it looks like the segfault was because I didn't wait(m), and m.figure must not have been defined at that point...

@asinghvi17 asinghvi17 changed the title Remove added tests to see if that fixes segfault Fix segfault in tests by waiting on map Dec 30, 2024
@asinghvi17
Copy link
Member Author

@rafaqz feel free to merge this branch into yours if you'd like, or we can merge to master.

@rafaqz rafaqz merged commit 7fa8e5b into master Dec 30, 2024
3 checks passed
@rafaqz rafaqz deleted the asinghvi17-patch-1 branch December 30, 2024 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants