Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raised Exception is not handled on iOS #552

Open
john-slow opened this issue Oct 9, 2024 · 2 comments
Open

Raised Exception is not handled on iOS #552

john-slow opened this issue Oct 9, 2024 · 2 comments

Comments

@john-slow
Copy link
Contributor

There is an edge case that occurs when the user clicks the "Done" button during login, which could potentially throw an error on the iOS platform:

* Terminating app due to uncaught exception 'An OAuth redirect was sent to a OIDExternalUserAgentSession after it already completed.', reason: 'An OAuth redirect was sent to a OIDExternalUserAgentSession after it already completed.'
*** First throw call stack:
(0x19f8a908c 0x19cbab2e4 0x19f9a4648 0x10238e284 0x10335b67c 0x1060fb1a4 0x1060cbe54 0x102d655b0 0x1a3123f1c 0x1a312396c 0x1c2c5c248 0x1c2c2c68c 0x19f8460f4 0x19f845144 0x10348271c 0x10348613c 0x1b8d5d3b8 0x1b8d5d338 0x1b8d5d210 0x19f87c088 0x19f87c01c 0x19f879b08 0x19f878d04 0x19f8785b8 0x1eb30e1c4 0x1a23ce2c0 0x1a247cddc 0x1a27a9b20 0x102e607e8 0x102e60760 0x102e60864 0x1c504cd34)
libc++abi: terminating due to uncaught exception of type NSException

This issue may be related to the following code, where the exception is not caught in the authorize function.

@MaikuB
Copy link
Owner

MaikuB commented Oct 10, 2024

Thanks for raising it. Would you by chance be able to submit a PR on this one?

@john-slow
Copy link
Contributor Author

Thanks for raising it. Would you by chance be able to submit a PR on this one?

Sure, I have created this pr to address this bug that you may review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants