Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Module] YetAnotherBootloopProtector #288

Open
rhythmcache opened this issue Jan 8, 2025 · 5 comments
Open

[Module] YetAnotherBootloopProtector #288

rhythmcache opened this issue Jan 8, 2025 · 5 comments
Assignees
Labels
feedback required Waiting for feedback llm Module written partially or fully by an LLM module A module submission

Comments

@rhythmcache
Copy link

ID

YetAnotherBootloopProtector

Name

Yet Another Bootloop Protector

Description

A Magisk Module to monitor and fix potential Bootloops and SystemUI failures.

Module repository link

https://github.com/rhythmcache/YetAnotherBootloopProtector

Source code link (for compiled binaries/APKs)

No response

Anti-Features

No response

@rhythmcache rhythmcache added the module A module submission label Jan 8, 2025
@Atrate Atrate self-assigned this Jan 9, 2025
@Atrate
Copy link
Member

Atrate commented Jan 9, 2025

Why do you use both of these files instead of just one? Wouldn't this cause conflicts, with multiple markers being created quickly?

https://github.com/rhythmcache/YetAnotherBootloopProtector/blob/main/post-fs-data.sh

https://github.com/rhythmcache/YetAnotherBootloopProtector/blob/main/service.sh

@Atrate Atrate added the feedback required Waiting for feedback label Jan 9, 2025
@rhythmcache
Copy link
Author

Screenshot_20250109-200415_Chrome Canary

what I read is that post-fs-data.sh is executed before service.sh. To confirm, I created another module and added a reboot command in its post-fs-data.sh. , but this module with just service.sh was not able to detect the bootloop issue, and my phone continued to be in a bootloop.
So, I added post-fs-data.sh to this module as well, and it detected it and disabled all the modules after the third bootloop."

@Atrate
Copy link
Member

Atrate commented Jan 9, 2025

This seems like a reasonable use for post-fs-data.sh as opposed to service.sh. Would it not make sense for you to rely only on post-fs-data and ditch service.sh altogether?

@Atrate Atrate added the llm Module written partially or fully by an LLM label Jan 9, 2025
@rhythmcache
Copy link
Author

rhythmcache commented Jan 9, 2025

Screenshot_20250109-221846_Chrome Canary

Well, the phone won't boot until the execution of post-fs-data.sh is complete.
To test this, I added the below commands to the post-fs-data.sh of a module, and my phone actually got stuck on the boot logo. Since this module is made to monitor system ui as well , running it in post-fs-data mode is useless. ..post-fs-data.sh will handle bootloops occurring at the blocking stage, while service.sh will handle bootloops occurring at the non-blocking stage.

LOG="/data/adb/logs.txt"
while true; do
    TIME=$(date "+%Y-%m-%d %H:%M:%S")
    echo "Script is running at $TIME" >> "$LOG"
    sleep 5
done

@Atrate
Copy link
Member

Atrate commented Jan 9, 2025

Okay, I see. I think this makes sense to me. @DerGoogler Any comments?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feedback required Waiting for feedback llm Module written partially or fully by an LLM module A module submission
Projects
None yet
Development

No branches or pull requests

2 participants