Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the store interface. #360

Open
MadcowD opened this issue Oct 31, 2024 · 1 comment
Open

Fix the store interface. #360

MadcowD opened this issue Oct 31, 2024 · 1 comment

Comments

@MadcowD
Copy link
Owner

MadcowD commented Oct 31, 2024

Some endpoints have sessions in the sql implementation as arguments wherease the parent store abstract base class does not actually have sessions. Need to rebuild the abstraction to respect this.
@MadcowD
Copy link
Owner Author

MadcowD commented Oct 31, 2024

eOne way to solve htis is that store abstraction is unidirectional and doesn't support reading.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@MadcowD