Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

invalid URI character when checking ODs #60

Open
MCOfficer opened this issue Feb 16, 2021 · 1 comment
Open

invalid URI character when checking ODs #60

MCOfficer opened this issue Feb 16, 2021 · 1 comment
Labels
bug Something isn't working

Comments

@MCOfficer
Copy link
Owner

Some ODs contain foreign characters that are considered invalid by curl. We should be able to urlencode them somehow.

f.e. http://www.gigglyhome.com/movie/모던패밀리1/
@MCOfficer MCOfficer added the bug Something isn't working label Feb 16, 2021
@Chaphasilor
Copy link

This is tricky. We could encode them, for sure. It's built right into JS, and maybe even Rust.

But I have a suspicion that there will be servers who won't accept the encoded characters for some reason.

We should try it out and monitor, if there are any issues...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Chaphasilor @MCOfficer