From 4f3746d9cde2ea4b28f1d571ba014559c4516d1c Mon Sep 17 00:00:00 2001
From: Jeremy Gebben <jeremyg@lunarg.com>
Date: Thu, 27 Jun 2024 15:57:28 -0600
Subject: [PATCH] cdl: Disable SemaphoreTracker::track_semaphores_last_setter

It doesn't work correctly right now.

See https://github.com/LunarG/CrashDiagnosticLayer/issues/70
---
 src/device.cpp            | 2 +-
 src/semaphore_tracker.cpp | 5 +++--
 src/semaphore_tracker.h   | 2 +-
 3 files changed, 5 insertions(+), 4 deletions(-)

diff --git a/src/device.cpp b/src/device.cpp
index 4c70343..b4b145d 100644
--- a/src/device.cpp
+++ b/src/device.cpp
@@ -55,7 +55,7 @@ Device::Device(Context& context, VkPhysicalDevice vk_gpu, VkDevice device, Devic
     }
     // Create a semaphore tracker
     if (context_.GetSettings().track_semaphores) {
-        semaphore_tracker_ = std::make_unique<SemaphoreTracker>(*this, context_.GetSettings().trace_all_semaphores);
+        semaphore_tracker_ = std::make_unique<SemaphoreTracker>(*this);
     }
 }
 
diff --git a/src/semaphore_tracker.cpp b/src/semaphore_tracker.cpp
index e42d829..b98d09b 100644
--- a/src/semaphore_tracker.cpp
+++ b/src/semaphore_tracker.cpp
@@ -38,8 +38,9 @@ void SemaphoreTracker::SemaphoreInfo::UpdateLastModifier(Device& device, Semapho
     last_id->Write(modifier_info.id);
 }
 
-SemaphoreTracker::SemaphoreTracker(Device& device, bool track_semaphores_last_setter)
-    : device_(device), markers_(device), track_semaphores_last_setter_(track_semaphores_last_setter) {}
+// TODO https://github.com/LunarG/CrashDiagnosticLayer/issues/70 track_semaphores_last_setter_ is broken
+SemaphoreTracker::SemaphoreTracker(Device& device)
+    : device_(device), markers_(device), track_semaphores_last_setter_(false) {}
 
 const Logger& SemaphoreTracker::Log() const { return device_.Log(); }
 
diff --git a/src/semaphore_tracker.h b/src/semaphore_tracker.h
index 145acee..2a7a76f 100644
--- a/src/semaphore_tracker.h
+++ b/src/semaphore_tracker.h
@@ -64,7 +64,7 @@ struct TrackedSemaphoreInfo {
 
 class SemaphoreTracker {
    public:
-    SemaphoreTracker(Device& device, bool track_semaphores_last_setter);
+    SemaphoreTracker(Device& device);
     SemaphoreTracker(SemaphoreTracker&) = delete;
     SemaphoreTracker& operator=(SemaphoreTracker&) = delete;