Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discussion: Mockup for V3 #138

Open
LordAmit opened this issue Jun 28, 2019 · 8 comments
Open

Discussion: Mockup for V3 #138

LordAmit opened this issue Jun 28, 2019 · 8 comments
Labels

Comments

@LordAmit
Copy link
Owner

@jahan-addison @apandada1 @sazid
https://github.com/LordAmit/Brightness/blob/mockups/Brightness_controller_v3.jpeg?raw=true

Check this out and let me know your thoughts. 💃

@jahan-addison
Copy link
Contributor

Looks great 🎉! Were you thinking of updating the stack any? Such as PyQt5/python 3.6+ :)

A new homepage could be nice too! We could go something simple like wp and just keep it up to date.

@jahan-addison
Copy link
Contributor

Also, check this out! https://github.com/gmarull/qtmodern

@archisman-panigrahi
Copy link
Contributor

archisman-panigrahi commented Jun 29, 2019

Also, we need to implement setup.py for Debian packaging.

@LordAmit
Copy link
Owner Author

@jahan-addison planning to go for PySide2. QtModern looks nice and all - but I am looking for something which will probably be maintained and supported for a long time.

@apandada1 - elaboration please :) Are we talking about continuous building?

@archisman-panigrahi
Copy link
Contributor

I am not sure what you meant by continuous building.
The setup.py file is used to generate the /usr/bin/brightness-controller file, which will call the other python files.

Previously we called init.py inside /usr/bin/brightness-controller to run the program. While it works, it is discouraged (by Debian maintainers) to run the program like this.

@jahan-addison
Copy link
Contributor

@LordAmit If you use something only once, does it matter the support? Once your mockup is implemented I dont see how a qt library's support changes anything.

@LordAmit
Copy link
Owner Author

It goes both ways, to be honest. Wrappers assume that libraries do not change, libraries assume that GUI APIs do not change.

All of these change at one time or another, inevitably breaking things.
Choosing stable options help increase maintainability by breaking less frequently. 😁

@apandada1 - probably you are talking about this then?

https://packaging.python.org/tutorials/packaging-projects/

Gotcha 💃

@jahan-addison
Copy link
Contributor

@LordAmit Stable != Support, but either way makes sense. I saw you already started a kanban board. When you fully flesh out expected MVP features, I'd love to grab a couple issues and get started 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants